search

Atleta-network / atleta

https://atleta.network
GNU General Public License v3.0
9 stars 5 forks source link

Lints tests too #93

Closed hrls closed 4 months ago

ales-tsurko commented 4 months ago

probably we should consider --all-features as well.

hrls commented 4 months ago

I got an error in the frontier sources when running with --all-features.

hrls commented 4 months ago

Tracking issue https://github.com/Atleta-network/atleta/issues/100

ales-tsurko commented 4 months ago

I got an error in the frontier sources when running with --all-features.

--no-deps?

hrls commented 4 months ago

Yep, no deps. I mean for some combination of features node and runtime doesn't compiles at all.

ales-tsurko commented 4 months ago

Yep, no deps. I mean for some combination of features node and runtime doesn't compiles at all.

It’s ok until it on our side, but if it shows issues to some 3rdparty code even with —no-deps flag, that’s odd.

hrls commented 4 months ago

What is especially interesting is that both of failed packages are checked successfully when run clippy with --all-features from their sources repos. I'll add failed pipeline in this issue just for shared logs to investigate.