AtmoOmen / CurrencyTracker

FFXIV Dalamud Plugin Currency Tracker
4 stars 1 forks source link

Bug: filtering and sorting options don't update the displayed table correctly #2

Closed PrincessRTFM closed 1 year ago

PrincessRTFM commented 1 year ago

It looks like changing the filtering options causes the list to be filtered not from the raw data but from the entries currently displayed in the list, and the "reverse sorting" option apparently only applies when the list is initially built. Changing any of the sorting and filtering options should probably rebuild the displayed list from the raw data in order to function as expected.

AtmoOmen commented 1 year ago

Thank you for your report. The issue has now been identified in the code. This problem arose because in the latest version update, I attempted to cache the transaction records on the first page to alleviate the lag caused by a large amount of data. However, I did not conduct further testing on the functionality related to filters. The issue has been fixed now, and I will push an update later to address this. I'm also sorry for any inconvenience this may have caused.

PrincessRTFM commented 1 year ago

All good! I figured it was because of the optimisations for large records mentioned in recent commits, but I wanted to report it in the hopes that some kind of middle ground could be reached. Glad to hear you found a way, and thanks for the cool plugin!

PrincessRTFM commented 1 year ago

This looks to be fixed, according to me poking around with the options in my game.