Overlayfs for exefs crashes instantly

Martmists-GH commented 2 years ago

Bug Report

What's the issue you encountered?

While developing mods, I often need to add an extra exefs file (e.g. subsdk1) that didn't exist in the exefs. However, putting these files in the exefs directory crashes the game instantly with "Could not start the software. Please try again from the HOME Menu".

How can the issue be reproduced?

create a file that didn't originally exist in exefs and put it in the exefs overlayfs directory.

Crash Report

N/A

System Firmware Version

13.2.0

Environment?

What bootloader (fusèe, hekate, etc) was Atmosphère launched by: Hekate
Official release or unofficial build: 1.2.5
Do you have additional kips or sysmodules you're loading: sys-ftpd-light, also happens without
Homebrew software installed: Amiigo, Checkpoint, Goldleaf, HB store, nxdumptool, nxgallery, nxshell, AIO switch updater, Daybreak, IPSwitch
EmuMMC or SysNAND: Partition-based EmuMMC

Additional context?

N/A

masagrator commented 2 years ago

This works without issue with skyline plugins. Issue is not with atmosphere but with your attempt to try link something that is not adjusted to this game. And this is not "overlayfs", it's called "layeredfs".

If you want to get help with subsdk linking, you can go to ReSwitched discord server and ask in #game-modding

Martmists-GH commented 2 years ago

Issue is not with atmosphere but with your attempt to try link something that is not adjusted to this game.

I'm trying to load it so I can see where it gets placed for use with Starlight, as documented here which states any valid subsdk1 should work just fine (and I'm using a subsdk1 valid for a previous version of the game). However, the game crashes instantly so the module doesn't get loaded.

Martmists-GH commented 2 years ago

Turned out to be a filezilla issue with newlines

breadbored commented 2 years ago

@Martmists-GH Can you expand on how FileZilla caused this? I'm having the exact same issue and I'm using FileZilla, however I'm also running sendPatch.py so the mod is uploaded via ftplib. What files were FileZilla causing issues with?

Martmists-GH commented 2 years ago

FileZilla's default behavior is to transfer extension-less files (like subsdk1) as text, replacing \n with \r\n which of course makes the game crash.

Atmosphere-NX / Atmosphere