Atmosphere-NX / Atmosphere

Atmosphère is a work-in-progress customized firmware for the Nintendo Switch.
GNU General Public License v2.0
15.08k stars 1.25k forks source link

[Feature Request] automatically delete old erpt reports #1795

Closed DraconicNEO closed 2 years ago

DraconicNEO commented 2 years ago

Feature Request

What feature are you suggesting?

Overview:

Have Atmosphere delete erpt reports automatically after a certain amount has been reached in the folder to prevent crashing from too many erpt reports.

Smaller Details:

Nature of Request:

[ Remove all that do not apply to your request. ]

What component do you feel this would best fit within?

Why would this feature be useful?

This feature addresses an issue where the erpt reports accumulate over time eventually exceeding the Switch's file limit and causing the error applet to crash. If this feature were implemented this crash could be avoided since old Erpt reports would be deleted and would never accumulate to the 16383 file limit.

SciresM commented 2 years ago

Unless a setting is switched away from default, erpt will now clean the report folder on boot if there are >= 1000 reports (or if reading the number of reports fails).

ImanCol commented 2 years ago

I think I've already requested this before in Hekate, but I was ignored.

When the partitions in the MicroSD are being resized from Hekate, these reports cause the process to slow down more.

https://github.com/CTCaer/hekate/issues/711#issue-1140136396

Masamune3210 commented 2 years ago

This has nothing to do with that, the slowness of backing up the erpt logs is caused by them being lots of small files which is inherently slow to deal with no matter the system or storage device due to inefficiencies. The solution to that is still the same, if you are making a backup delete the logs unless you need them for something

ImanCol commented 2 years ago

Or something better, disable creating logs, if the user is not reporting bugs. In addition, it will increase the life cycle of the MicroSD.

Masamune3210 commented 2 years ago

Logs are on for a reason, issues don't always manifest before they become an imperative

SciresM commented 2 years ago

Or something better, disable creating logs, if the user is not reporting bugs. In addition, it will increase the life cycle of the MicroSD.

I am not going to disable log creation.

ImanCol commented 2 years ago

Rarely did I get a blue screen from atmosphere, but they still generate intangible amounts of log files. All I have to do is write-protect the folder. image

Masamune3210 commented 2 years ago

This will prevent the folder from growing past a certain point, and just because you arent getting full crashes doesn't mean errors arent happening. erpt isn't going to just spit out a log saying All is OK, if its making logs its for a reason

ImanCol commented 2 years ago

Well, hopefully that option to delete records when it exceeds a certain amount is added.

Masamune3210 commented 2 years ago

The commit is already done, unless something changes its happening image