Atmosphere-NX / Atmosphere

Atmosphère is a work-in-progress customized firmware for the Nintendo Switch.
GNU General Public License v2.0
14.29k stars 1.21k forks source link

Exosphere's PRODINFO blanking is broken on 17.0.0 - Needs to be removed to avoid confusion. #2215

Closed Sanrax closed 10 months ago

Sanrax commented 10 months ago

Bug Report

What's the issue you encountered?

Applying blanked PRODINFO on HOS 17.0.0 with AMS 1.6.0 or 1.6.1's exosphere causes a crash, ProgramID - 0100000000000025

If this is an unfixable issue, the feature should be removed from Atmosphere.

How can the issue be reproduced?


Create an exosphere.ini file that has blank_prodinfo set to 1, and boot into a partition running 17.0.0.

System Firmware Version

17.0.0

Environment?

SciresM commented 10 months ago

I am not sure about removing it, because then people who are using it might get really mad. Consider someone who is on 15.0.0, using blanking. If I just outright remove it, then they'll boot into 15.0.0 and their console will connect to Nintendo, and they might yell at me. Same deal with making it silently do nothing on 17.0.0, where they'd think it's on but it isn't.

I'm thinking on it, but the crash might honestly be the best outcome.

Masamune3210 commented 10 months ago

I'd argue the crash is the best outcome, since its a hard stop that forces the person to figure out what is going on and doesn't invisibly invalidate their intention of keeping the option enabled.

SciresM commented 10 months ago

Yeah. That's kind of how I feel, that it's better than an invisible lack of blocking when the user expects blocked domains.

Sanrax commented 10 months ago

Yeah. That's kind of how I feel, that it's better than an invisible lack of blocking when the user expects blocked domains.

True. Would it be possible to cause a custom error or crash that would make it more clear perhaps? I feel like having a random process ID shown doesn't make it very clear what the issue is.

SciresM commented 10 months ago

Not really, since the error occurs in a Nintendo module with no atmosphere code involved. I could maybe adjust the fatal text if the version is high enough and it's that specific error code from that specific module, but I really don't like fucking with the fatal error text.

I can try to think about whether there are any less obvious things to do.

Sanrax commented 10 months ago

Cool. Best of luck then, and thanks for maintaining Atmos. :)

Masamune3210 commented 10 months ago

Maybe put a warning somewhere and offer a list of all known domains that need to be blocked?

and yeah, thanks for doing all of this

Sanrax commented 10 months ago

Maybe put a warning somewhere and offer a list of all known domains that need to be blocked?

and yeah, thanks for doing all of this

Personally, I would ship nh-server guide's emummc.txt as part of official ams. The couple people that need Nintendo servers on emummc can remove the file themselves.

SciresM commented 10 months ago

Well, keep in mind that I literally don't recommend emummc. Almost everyone doesn't need it; I boot exclusively sysmmc, and mostly recommend this. I wouldn't want the defaults to ever be "servers blocked", I don't think.

Sanrax commented 10 months ago

I wouldn't want the defaults to ever be "servers blocked", I don't think.

I mean, the emummc file only applies to emu, so the default recommended configuration (sysCFW) would still have servers unblocked.

I can't think of a single reason anyone would need unblocked Nintendo on emu, other than people running patched Eristas on 4.1.0.

Almost everyone doesn't need it

I think we both know that the vast majority of AMS users with unbanned Switches do use emu though, to evade bans.

SciresM commented 10 months ago

I honestly don't believe that's true. Not being performative or disingenuous; it is my honest expectation that that's not the case.

josete2k commented 10 months ago

I know that this is a closed threat but I have blanked serial on emummc and no error when updating to 17.0.0

If I can help you just let me know...

AntHJ commented 10 months ago

If the serial was removed previously using incognito, would the system have the same crash issue?

SciresM commented 10 months ago

If the serial was removed previously using incognito, would the system have the same crash issue?

The issue isn't the serial, it's the cert stuff. So would depend on whether the certificate was messed with.

CrimsonKnight13 commented 10 months ago

I've found the crash happens only after WiFi is connected. It remains perfectly stable with airplane mode.

filipecoimbra222 commented 10 months ago

I've found the crash happens only after WiFi is connected. It remains perfectly stable with airplane mode.

I can confirm it. I'm having the exactly same error, but when i put it in Airplane mode, the crash does not occur. I'm kinda new to Switch CFW. Is there any way i can solve this for now?

Masamune3210 commented 10 months ago

Turn off PRODINFO blanking and either deal with having a banned console or block all the domains

CrimsonKnight13 commented 10 months ago

I've found the crash happens only after WiFi is connected. It remains perfectly stable with airplane mode.

I can confirm it. I'm having the exactly same error, but when i put it in Airplane mode, the crash does not occur. I'm kinda new to Switch CFW. Is there any way i can solve this for now?

I used the old Incognito_RCM payload to erase my PRODINFO, so restoration via any Homebrew app wouldn't work.

If you used any method for Incognito mode, restore PRODINFO (if you backed up full NAND or partitions) with NxNandManager. I no longer have the issue after restoration.

filipecoimbra222 commented 10 months ago

I've found the crash happens only after WiFi is connected. It remains perfectly stable with airplane mode.

I can confirm it. I'm having the exactly same error, but when i put it in Airplane mode, the crash does not occur. I'm kinda new to Switch CFW. Is there any way i can solve this for now?

I used the old Incognito_RCM payload to erase my PRODINFO, so restoration via any Homebrew app wouldn't work.

If you used any method for Incognito mode, restore PRODINFO (if you backed up full NAND or partitions) with NxNandManager. I no longer have the issue after restoration.

Thanks for the reply. I managed to use a AMS DNS redirection as a workaround (blocking all Nintendo Servers), then turned off blank PRODINFO. Everything is working now.

SciresM commented 10 months ago

Locking this, as it's been resolved for a while.