Atmosphere / atmosphere-javascript

atmosphere-javascript
Apache License 2.0
122 stars 98 forks source link

Fix streaming reconnect on IE9 #201

Closed Artur- closed 8 years ago

Artur- commented 8 years ago

Streaming reconnect fails on IE9 with an exception message "Unable to get value of the property 'cloneNode': object is null or undefined"

This happens when trying to write a

tag to an iframe document when the iframe fails to load (network error) and later on attempting to use that tag which was never written.</p> <p>In the JQuery version, reconnect happened to work as the exception was accidentally triggered earlier by comparing the node tag name to &quot;pre&quot;. As the node was null, an exception was thrown, but the it was thrown early enough to be inside a try block so it was caught and handled. This caused reconnect to work in that version.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/jfarcand"><img src="https://avatars.githubusercontent.com/u/51285?v=4" />jfarcand</a> commented <strong> 8 years ago</strong> </div> <div class="markdown-body"> <p>@Artur- Do you need an official release?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Artur-"><img src="https://avatars.githubusercontent.com/u/260340?v=4" />Artur-</a> commented <strong> 8 years ago</strong> </div> <div class="markdown-body"> <p>No need, I'll make a custom release</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>