maxWebsocketErrorRetries not working as expected - Githubissues

Atmosphere / atmosphere-javascript

atmosphere-javascript

Apache License 2.0

122 stars 98 forks source link

maxWebsocketErrorRetries not working as expected #242

Open mihaisdm opened 5 years ago

mihaisdm commented 5 years ago

Hello,

I was expecting to try to reconnect using WebSocket until maxWebsocketErrorRetries is reached, after try fallback mechanism.

Should be "_request.curWebsocketErrorRetries++ >_request.maxWebsocketErrorRetries? not less. Else i do not understand the purpose.

https://github.com/Atmosphere/atmosphere-javascript/blob/eddfa5e8c632fcbfa60fb66fadfdd8095b39b473/modules/javascript/src/main/webapp/javascript/atmosphere.js#L1482

Thank you Mihai

SuperPat45 commented 5 years ago

Done