search

Atmosphere / atmosphere-javascript

atmosphere-javascript
Apache License 2.0
122 stars 98 forks source link

Enable IPv6 by escaping [ and ] caracters to not be encoded #243

Closed petregeorgee closed 5 years ago

petregeorgee commented 5 years ago

This pull request resolves the following issue: https://github.com/vaadin/framework/issues/11458

Regards, George

petregeorgee commented 5 years ago

Hello jfarcand

Can you please help me to resolve this little bug? I am very blocked. https://github.com/vaadin/framework/issues/11458

Thank you so much, George

jfarcand commented 5 years ago

@petregeorgee Can you rebase your fix?

petregeorgee commented 5 years ago

@jfarcand rebase done. I don't know why, after the rebase, GitHub told me that those two branches had conflicts and I had to resolve them.

Thank you, George

petregeorgee commented 5 years ago

Thanks!!

petregeorgee commented 5 years ago

Hello @jfarcand.

I only have a little question: in which release these changes will be available?

Thank you in advance, George

jfarcand commented 5 years ago

2.3.9 should be available on Maven Central as of now.

petregeorgee commented 5 years ago

I can't see it. The latest version of the project is 2.3.8, released on Oct 2018 link

Other than that I need to use this dependency: "com.vaadin.external.atmosphere:atmosphere-runtime" for my project. Do you know a person with I can talk about this?

jfarcand commented 5 years ago

https://search.maven.org/search?q=atmosphere-javascript