search

Atmosphere / atmosphere-javascript

atmosphere-javascript
Apache License 2.0
122 stars 98 forks source link

Invalid html code used #260

Closed kozi closed 4 years ago

kozi commented 4 years ago

The HTML-Code used in the line 916 and line 3124 is not valid because iframe and a are no void elements.

916

https://github.com/Atmosphere/atmosphere-javascript/blob/19f72c23d4248d6065f3873d46f179e084a13b7b/modules/javascript/src/main/webapp/javascript/atmosphere.js#L916

Must be: 

container.innerHTML = '<iframe name="' + neim + '"></iframe>';

3124

https://github.com/Atmosphere/atmosphere-javascript/blob/19f72c23d4248d6065f3873d46f179e084a13b7b/modules/javascript/src/main/webapp/javascript/atmosphere.js#L3124

Must be: 

div.innerHTML = '<a href="' + url + '"></a>';
jfarcand commented 4 years ago

@kozi Could you do a pull request? Once done I will cut a new release. Thanks!