search

Atmosphere / wasync

WebSockets with fallback transports client library for Node.js, Android and Java
http://async-io.org
161 stars 47 forks source link

Replace only the protocol part of the URL in Socket#connect. #82

Closed bartfaitamas closed 10 years ago

bartfaitamas commented 10 years ago

In method DefaultSocket#connect, the code replaces all "http" or "ws" substrings, not just the protocol part.

buildhive commented 10 years ago

Atmosphere Framework » wasync #429 UNSTABLE Looks like there's a problem with this pull request (what's this?)

jfarcand commented 10 years ago

Good catch...but wss and https won't be covered. Can you improve your patch with that scenario? Thanks!

buildhive commented 10 years ago

Atmosphere Framework » wasync #430 UNSTABLE Looks like there's a problem with this pull request (what's this?)

jfarcand commented 10 years ago

Thanks!!! Let me know how it goes with the test. I do see failure here, but never locally.