search

AtomBombf13 / AtomBomb

GNU Affero General Public License v3.0
5 stars 51 forks source link

var/flags_inv is not working as intended #296

Open Pebblesthe2nd opened 1 year ago

Pebblesthe2nd commented 1 year ago

Used heavily in root items for helmets Supposed to make stuff invisible (such as ear items, so the ear piece does not clip

What it does instead: Makes it impossible to remove or place a item in the ear slot (or eyeslot, depending what you flagged) giving the error message "the mask is in the way"

It does not make anything invisible, still clips.

xTrainx commented 1 year ago

Cannot reproduce, though trying to remove an ear piece with a helmet on doesn't let you take it but I assume that's intendes

Pebblesthe2nd commented 1 year ago

This is easiest to reproduce by A: doing a test edit of a hat that doesnt have the flag. I recommend using /obj/item/clothing/head/helmet/fashion/cowboy/blondie and just add flags_inv = HIDEEARS at the end.

B: spawn a bald naked man C: spawn the following /obj/item/radio/headset/headset_town/lawman_sheriff /obj/item/clothing/head/helmet/fashion/cowboy/blondie /obj/item/clothing/head/helmet/fashion/cowboy D: Notice how if you wear the flagged testhat (blondie) you can suddenly not unequip the radio, and furthermore, the radio sprite is simply not invisible. The flag does not do what its supposed to.

So, it is reproducable, and the bug is that it does not make the earpiece invisible as its intended, instead it makes it impossible to access the slot.

xTrainx commented 1 year ago

ok, i was thinking the problem was it was clipping through helmets, i get it now, but not being able to access the headpiece is intentional, it just a lot of items that shouldn't be classified as helmet are a subtype of such, so their flags_inv should be changed to reflect those that can and cannot hide the ears