search

AtomBuild / atom-build-make

GNU Make plugin for atom-build
MIT License
13 stars 19 forks source link

Fix gcc regular expression to also work with windows paths #23

Closed aroig closed 8 years ago

aroig commented 8 years ago

Absolute paths on windows start with a drive letter. Without this patch, an error message like

C:/blah/blah.cpp:10:6 ....

will only match /blah/blah.cpp as a file path, and we are not able to jump to the source code from the error.

Edit: Oh, and I did not touch the ocaml regexp because I can't test it easily but it probably has the same problem.

noseglid commented 8 years ago

On windows, Isn't paths case insensitive so c:\ is the same as C:\ ?

aroig commented 8 years ago

On windows, Isn't paths case insensitive so c:\ is the same as C:\ ?

Yes.

noseglid commented 8 years ago

Cool thanks!