search

AtomGraph / LinkedDataHub

The low-code Knowledge Graph application platform. Apache license.
https://atomgraph.github.io/LinkedDataHub/
Apache License 2.0
485 stars 122 forks source link

Make Content Type Optional for File Uploads #110

Closed tmciver closed 2 years ago

tmciver commented 2 years ago

The script create-file.sh expects the file's content type to be provided by the caller. It would be convenient to make the content type optional and be automatically determined when not provided. This would also make it less likely that the caller-provided content type would be inconsistent with the actual content type of the file.

namedgraph commented 2 years ago

Thanks @tmciver, this makes sense! I'll try it out ASAP.

namedgraph commented 2 years ago

Hi @tmciver. I didn't want to fix the conflicts in #111 but I incorporated your changes into the develop branch: https://github.com/AtomGraph/LinkedDataHub/commit/1babfac2535ffff4327806329eaaca75d74a9479 Our tests pass, so that's OK from me. Can you see if they work for you? develop also comes with an improved graph layout ;) If they do, we can close this. Thanks for the contribution!

tmciver commented 2 years ago

I ran LDH from the latest develop (https://github.com/AtomGraph/LinkedDataHub/commit/1babfac2535ffff4327806329eaaca75d74a9479) and it works great! Thanks!

And the graph layout does look better! I'm looking forward to it being interactive. :)