path.dirname is deprecated.

AtomLinter / linter-codeclimate

An Atom Linter plugin for the Code Climate CLI

http://github.com/codeclimate/codeclimate

MIT License

10 stars 5 forks source link

path.dirname is deprecated. #55

Closed leonelgalan closed 6 years ago

leonelgalan commented 7 years ago

Argument to path.dirname must be a string

path.dirname (/Applications/Atom.app/Contents/Resources/app.asar/src/electron-shims.js:9:10)
Object.<anonymous> (/Users/leonelgalan/.atom/packages/linter-codeclimate/lib/index.js:122:42)
undefined.next (null:null:null)
step (/Users/leonelgalan/.atom/packages/linter-codeclimate/lib/index.js:7:273)

End of automated report

How do we help? Is this going to be handled automatically once atom-linter is published?

Arcanemagus commented 7 years ago

Fixed in v0.2.3, thanks for the report 😉.

jaredallard commented 6 years ago

Getting this in 0.2.5

(sorry couldn't figure out how to get the stack trace)

Arcanemagus commented 6 years ago

@jaredallard That's actually a separate issue. Clicking the "Report Issue" button would have started filing an issue with all the relevant information for you btw 😉.

If anyone wants to put together a PR fixing this it should be as simple as adding these checks here: https://github.com/AtomLinter/linter-codeclimate/blob/05bc926013f34341ceb8ae438f1c44b36ad3d316/lib/index.js#L132

jaredallard commented 6 years ago

@Arcanemagus It took me to this thread with the "Report Issue" button 🤷‍♀️