search

AtomLinter / linter-codeclimate

An Atom Linter plugin for the Code Climate CLI
http://github.com/codeclimate/codeclimate
MIT License
10 stars 5 forks source link

Let CodeClimate decide which engines to run #67

Closed pointlessone closed 7 years ago

pointlessone commented 7 years ago

This PR removes hardcoded engines and instead lets CC decide which engines to run. This closer matches default CC CLI behaviour.

As a side effect this eliminates a few dependencies as it's not needed to find and parse CC config.

Bonus: fixed end column for issue ranges.

pointlessone commented 7 years ago

Yesterday Code Climate CLI 0.63.2 was released. It addresses the file name validation.

@cgalvarez You may want to rerun a build on your PR.

@Arcanemagus I addressed all your comments. Could you please take a look at this PR again?

cgalvarez commented 7 years ago

@pointlessone Thank you very much for the pin.

I've tested with the latest Code Climate (v0.63.5) and the errors are gone :smile: :clap: :clap:

Arcanemagus commented 7 years ago

@AtomLinter/linter-codeclimate I don't use this package myself, so others get a higher priority when I have time to work on stuff, so things like this can get somewhat delayed if you leave it up to me 😛.

You should definitely feel free to merge PR's and release updates, if you have any questions on that feel free to @mention me or even better bug me on Atom's Slack.

maxjacobson commented 7 years ago

Ah right, I forgot that I can merge things :sweat_smile:. Thanks. I definitely have some questions about the build & release process, so I may be bugging you about those on slack :)