search

AtomLinter / linter-codeclimate

An Atom Linter plugin for the Code Climate CLI
http://github.com/codeclimate/codeclimate
MIT License
10 stars 5 forks source link

Asyncify the specs #74

Closed Arcanemagus closed 6 years ago

Arcanemagus commented 6 years ago

Bring in jasmine-fix to allow the use of async/await in the specs and refactor them to take advantage of this.

Arcanemagus commented 6 years ago

This being impossible to debug on Windows makes this very difficult to work on.... as far as I can tell from the debug statements codeclimate is somehow taking over 10 seconds to return, so the specs just give up on it and fail.

Arcanemagus commented 6 years ago

As there isn't really much point in bringing this in for just the beforeEach block, and it looks like the actual test can't be (easily) run with async, I'm just going to close this PR for now.

Arcanemagus commented 6 years ago

Anyone that's able to run this locally want to check on why this isn't working? The CI build isn't even printing the debug text...

cgalvarez commented 6 years ago

I'm currently having problems with the tests on #83 , so I'm trying to fix them with your approach here.

@Arcanemagus I cannot get your debug messages printed too, so I've used another approach: writing a log file. I've checked that in my case, I'm getting messages = null, so I suspect that's what happening to you here, and that's why the CI build fails with TypeError: Cannot read property 'length' of null.

Keep on digging into this, but any help would be greatly appreciated :wink:

cgalvarez commented 6 years ago

Finally got to understand this weird behavior.

When running specs, no timeout is provided to Helpers.exec(...), so after the @Arcanemagus ' mythical 10s :stuck_out_tongue: the cli is killed and null is returned.

I'm fixing this issue in #83 too, since I need it to get tests passing.