AtomLinter / linter-codeclimate

An Atom Linter plugin for the Code Climate CLI
http://github.com/codeclimate/codeclimate
MIT License
10 stars 5 forks source link

`sb-exec` reporting non-zero exit code #79

Open cgalvarez opened 6 years ago

cgalvarez commented 6 years ago

It seems that sb-exec is reporting that cc-cli is exiting with non-zero code. That is populating my Atom console with lots of console.error(...) messages, printing there all the data that the cli outputs.

When I exec the cli locally, I get an exit code $? of 0, so don't know why this is happening, but it's very annoying. As a temporary workaround, I can pass option ignoreExitCode: true here, and now the package works flawlessly.

@Arcanemagus Let me know if you want me to make a PR with the temporary workaround :wink:

cgalvarez commented 6 years ago

Just checked that exitCode === null when reaching this line, but the captured output is fine, and the spawned process exit flawlessly. Seems to be a bug of sb-exec.

cgalvarez commented 6 years ago

Filed an issue on sb-exec repo to get this bug fixed.