search

AtomLinter / linter-eslint-node

ESLint plugin for Atom/Pulsar Linter (v8 and above)
https://web.pulsar-edit.dev/packages/linter-eslint-node
MIT License
4 stars 3 forks source link

This package has a hard dependency to Eslint v7.29.0(+) #27

Closed sjuvonen closed 1 year ago

sjuvonen commented 2 years ago

I was running this plugin and working on a codebase where we had installed eslint:7:24.0. According to the package documentation we can safely use this plugin with any eslint >=7.0.0.

However, I was faced with the following error message in Atom: eslint.eslintLint.getRulesMetaForResults is not a function.

So, I looked up this method in Eslint's sources and it seems that it has been added in version 7.29.0, hence making it the minimum supported version.

See the commit here

I've now upgraded to eslint:7.32.0 and everything seem to be working so far, so I cannot comment on whether or not there could be further breakage if I was actually trying to use version 7.29.0

sjuvonen commented 2 years ago

Tbh this requirement hardly makes this package "compatible with v7", so I would just drop that nonsense and instead advertise only support for v8+.

savetheclocktower commented 2 years ago

Thanks. I'll look into either (a) removing the assumption that getRulesMetaForResults is present… or (b) clarifying which versions of ESLint v7 are supported.

savetheclocktower commented 1 year ago

This got fixed in #28. We're not publishing to Pulsar's package repo yet, but those who installed straight from GitHub (ppm install AtomLinter/linter-eslint-node) will get the update, I think.