search

AtomLinter / linter-eslint-node

ESLint plugin for Atom/Pulsar Linter (v8 and above)
https://web.pulsar-edit.dev/packages/linter-eslint-node
MIT License
4 stars 3 forks source link

PPM upgrades aren't happening when installed from git #35

Closed savetheclocktower closed 1 year ago

savetheclocktower commented 1 year ago

Issue Type

Bug (though not our bug)

Issue Description

I know exactly what's going on and have opened an issue on PPM: because our default branch is main, the PPM CLI fails to see the newest SHA when one runs ppm upgrade linter-eslint-node.

This affects anyone who installed via ppm install AtomLinter/linter-eslint-node, and affects users of apm as well.

Workarounds

I think the fix is pretty simple on the PPM end, but another option is to rename our default branch to master. I don't have a strong opinion about this.

savetheclocktower commented 1 year ago

OK, good news is that my PR for ppm landed and should go out in the next Pulsar release, so I don't think this is worth working around on our end.

savetheclocktower commented 1 year ago

Pulsar v1.102.0 is out, so anyone who uses linter-eslint-node via Pulsar should make sure to download it (since auto-updates aren't working yet). I'll wait to close this until the next time we land something to main so I can be absolutely sure that this is fixed.

scagood commented 1 year ago

@savetheclocktower is this resolved now?

savetheclocktower commented 1 year ago

I'm pretty sure it is. If I'm wrong, I'll re-open it after the next update.