chore: Convert the worker.js file into multiple smaller files

[scagood]

This does the following:

• Adds a .editorconfig
• Moves worker.js to worker/worker.js
• Abstracts away the message response, logging and error handling
• Makes the worker using the following structure:

  Filename	Description
  convert-results.js	Converts ESLint.LintResult[] into atom-linter results
  errors.js	Holds all (known) emitted errors
  eslint.js	Retrieves the ESLint instance and manages caching
  fs-utils.js	Store the file searching tools
  messaging.js	Abstracts away the event messaging
  worker.js	The main worker entry point

[savetheclocktower]

On first glance this seems fine, but was there a pressing need to break up a file that was under 500 LOC?

[scagood]

@savetheclocktower I am gearing up torwards the FlatESLint class 😀 https://eslint.org/blog/2022/08/new-config-system-part-3

[savetheclocktower]

Wow, that was not on my radar. Much appreciated.

I don't know if you're any good with CI stuff, but our jobs need retrofitting to work with Pulsar. @UziTech pointed me to setup-pulsar a while back, but I haven't had time to investigate, because I'm spending a lot of time working on Pulsar's core. I haven't even gotten far enough to ascertain whether it's mature enough for us to be able to do a simple swap for setup-atom.

If you're willing to give this a try, it would be a huge help; otherwise we're in a position where we have to make disruptive changes to the codebase without being able to rely on CI. If it's something you despise doing, then I can give it my best shot.

[scagood]

I can certainly give it a shot 😄 I will set up all the actions on my fork to test I think. May not have time till the weekend though

[savetheclocktower]

Strangely, all tests pass when I run pulsar --test spec from the command line, but I get seven failures when I run Run Package Specs from the GUI. Annoying, but not a deal-breaker.

The test you skipped works fine for me locally if I un-skip it. If increasing the timeout helps the test pass for you locally, let's try that.

[scagood]

Draft CI found in #39 Not sure why installing other packages did not work out 🤔

[scagood]

mmm, rebase tests failed, will look later 😂

[scagood]

Urm, can someone better versed in windows help 👀

I am so lost, I cant get the tests to fail 😬

[savetheclocktower]

I'm on macOS, so I'll be of no help, sadly.

[scagood]

I now have all major OS distros installed, my daily driver is also mac 😂