search

AtomLinter / linter-eslint-node

ESLint plugin for Atom/Pulsar Linter (v8 and above)
https://web.pulsar-edit.dev/packages/linter-eslint-node
MIT License
4 stars 3 forks source link

ci: use pulsar in ci #39

Closed scagood closed 1 year ago

savetheclocktower commented 1 year ago

Thank you so very much for doing this.

Looks like you got Windows working — are we good to land this PR?

savetheclocktower commented 1 year ago

Ah, I see some of the tests are still skipped. Never mind.

scagood commented 1 year ago

This is just because the ppm install linter-eslint just does not seem to install linter-eslint. So the tests all throw an error saying as much.

See: https://github.com/scagood/linter-eslint-node/actions/runs/5484423520/jobs/9991948934

savetheclocktower commented 1 year ago

Maybe try installing from GitHub just for fun?

ppm install AtomLinter/linter-eslint
scagood commented 1 year ago

😢

scagood commented 1 year ago

It looks to be intstalled 🤔 This is very odd.

image
savetheclocktower commented 1 year ago

Oh, the package path in package-integration-spec.js is still hard-coded:

const packagesRoot = Path.join(root, '.atom', 'packages');

Try switching that to .pulsar.

scagood commented 1 year ago

Aaaah, dang it, the same thing has happened in a couple of places.

Please hold 🎶

scagood commented 1 year ago

Well, I dislike windows 😂

image
scagood commented 1 year ago

Created a PR here to save the action costs 👀 https://github.com/scagood/linter-eslint-node/pull/1

scagood commented 1 year ago

@savetheclocktower What do you think of the hack for installing deps on windows?

If its reasonable we could look to merge this. May see if I can get a windows machine and also try to fix ppm/pulsar -p

scagood commented 1 year ago

@savetheclocktower Should we progress this PR?

savetheclocktower commented 1 year ago

Looks like we're good. I'll land this and then you can rebase #38 and #41. Thanks a lot!

Another thing we should tackle in the future is automatic release to the Pulsar Package Repository, but that might require some small amount of @UziTech's time just to work out how to generate and store a secret token. It can wait.