AtomLinter / linter-glsl

Atom package that lints GLSL shaders on the fly.
https://atom.io/packages/linter-glsl
MIT License
15 stars 6 forks source link

Lint on the fly #1

Closed kankaristo closed 8 years ago

kankaristo commented 8 years ago

Thanks for creating this package, it's very useful.

However, this is the only Atom linter that I've come across that doesn't lint on the fly. Is there some particular reason for this?

Performance doesn't seem to be an issue (on my machine). Could this be added as a setting?

andystanton commented 8 years ago

Hi @kankaristo, thanks for the feedback!

The reason was that glslangValidator can only read files, so to lint on the fly (i.e. without saving the file), you have to create a temporary file with the unsaved content and pass that to glslangValidator. I didn't know how to do that, but now I do.

I've added this feature and published v1.0.2 - let me know if there are any issues.

kankaristo commented 8 years ago

Seems to be working well, thanks for fixing this so quickly!