search

AtomLinter / linter-glsl

Atom package that lints GLSL shaders on the fly.
https://atom.io/packages/linter-glsl
MIT License
15 stars 6 forks source link

Add support for tessellation control, tessellation evaluation and compute shader #23

Closed StailGot closed 8 years ago

andystanton commented 8 years ago

Hi @StailGot, thanks for the PR!

I think it's the right thing to do to drop the .(v|f|g).glsl, _(v|f|g).glsl, .(v|f|g)sh and .(v|f|g)shader file extensions but this has made the tests fail because there were tests for each of the file extensions.

Here is a patch that fixes the broken tests and adds in new ones for tese, tesc and comp shaders: https://gist.githubusercontent.com/andystanton/fc2efb9e9884cc7c5c60/raw/d7b6e429c09d4e94da5266a6feb1d15ecd113ee1/test-fixes-23.patch

You can run the tests locally with apm test.

StailGot commented 8 years ago

Hi @andystanton. Thanks for fast response. Patch applied, and all tests correct now.

andystanton commented 8 years ago

Thanks @StailGot.

I've published a new major version of linter-glsl as this change breaks compatibility with some previously supported (though unofficial) shader filename patterns.