Closed greenkeeperio-bot closed 7 years ago
@andystanton I've updated the expected messages for Windows.
(This is why most linters just check the first message: If it's working at all that will be there, any further messages are usually just validating the linter itself instead of the translation into Atom)
Looks like CircleCI is still failing, on to that now...
Dang, looks like my keys don't allow access to the CircleCI SSH.
Hmmmm, can't reproduce on a local Ubuntu instance either :/
One thing I've noticed is that the downloadable versions of glslangValidator from the Khronos website which are used in the Windows and Linux builds, have been bumped without a corresponding tag in their source. The OSX one comes from homebrew and is built from the latest tag so has a different version.
Glslang Version: SPIRV99.947 15-Feb-2016
Glslang Version: 3.0.729 19-Aug-2015
Glslang Version: 3.0.790 15-Oct-2015
Closing this as the CI issues have been addressed and a small linting tweak made.
Hello lovely humans,
atom-linter just published its new version 8.0.0.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of atom-linter. Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right? Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project :sparkles:
You rock!
:palm_tree:
The new version differs by 13 commits .
54ed631
:arrow_up: Bump version to 8.0.0
465e85f
Merge pull request #145 from steelbrain/steelbrain/maintenance
4011eb6
:bug: Correct flow config ignore rule
0a14697
:bug: Fix for specs compatibility
e6e9a9e
:art: Address reviewer's comments
8901c71
:art: Very minor cleanup
029745d
:art: Fix flow errors in specs
957acac
:art: Fix flow errors in main module
913890f
:new: Add decls for flow
808811c
:new: Run flow in CI and upgrade deps
a804def
Merge pull request #144 from steelbrain/steelbrain/latest-sb-exec
02886b5
:art: Capitalize Windows in CHANGELOG
b668da2
:arrow_up: Bump sb-exec@3.x
See the full diff.
This pull request was created by greenkeeper.io.
Tired of seeing this sponsor message? :zap:
greenkeeper upgrade