AtomLinter / linter-glsl

Atom package that lints GLSL shaders on the fly.
https://atom.io/packages/linter-glsl
MIT License
15 stars 6 forks source link

Update atom-linter to version 8.0.0 🚀 #42

Closed greenkeeperio-bot closed 7 years ago

greenkeeperio-bot commented 8 years ago

Hello lovely humans,

atom-linter just published its new version 8.0.0.

State Update :rocket:
Dependency atom-linter
New version 8.0.0
Type dependency

This version is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of atom-linter. Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right? Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project :sparkles:

You rock!

:palm_tree:


The new version differs by 13 commits .

See the full diff.


This pull request was created by greenkeeper.io.

Tired of seeing this sponsor message? :zap: greenkeeper upgrade

Arcanemagus commented 8 years ago

@andystanton I've updated the expected messages for Windows.

(This is why most linters just check the first message: If it's working at all that will be there, any further messages are usually just validating the linter itself instead of the translation into Atom)

Arcanemagus commented 8 years ago

Looks like CircleCI is still failing, on to that now...

Arcanemagus commented 8 years ago

Dang, looks like my keys don't allow access to the CircleCI SSH.

Arcanemagus commented 8 years ago

Hmmmm, can't reproduce on a local Ubuntu instance either :/

andystanton commented 7 years ago

One thing I've noticed is that the downloadable versions of glslangValidator from the Khronos website which are used in the Windows and Linux builds, have been bumped without a corresponding tag in their source. The OSX one comes from homebrew and is built from the latest tag so has a different version.

Linux:

Glslang Version: SPIRV99.947 15-Feb-2016

OSX 3.0 (via homebrew & built from latest available tag)

Glslang Version: 3.0.729 19-Aug-2015

OSX SPIRV99 (checked out and built from SPIRV99 tag to compare version)

Glslang Version: 3.0.790 15-Oct-2015
andystanton commented 7 years ago

Closing this as the CI issues have been addressed and a small linting tweak made.