search

AtomLinter / linter-glsl

Atom package that lints GLSL shaders on the fly.
https://atom.io/packages/linter-glsl
MIT License
15 stars 6 forks source link

Can't find glslValidator.exe #6

Closed ricanteja closed 8 years ago

ricanteja commented 8 years ago

There is a problem locating the glslValidator. Before the most recent update I had it set up to a specific path but now it can't find it and even if I add it to the System Path it doesn't work. Some change in the most recent update broke this. I'm on Windows 7

Thanks for the neat plugin!

andystanton commented 8 years ago

Apologies @ricanteja I didn't test on Windows before the last release.

I've unpublished 1.0.3 until I can test the change on Windows. In the meantime you might need to reinstall linter-glsl as I'm not sure Atom will prompt you to downgrade it to 1.0.2.

andystanton commented 8 years ago

I had problems republishing 1.0.3 so I had to bump up to 1.0.4, but the fix is now available through apm.

The bug was due to me assuming fs.accessSync returns a boolean. It doesn't - it throws an exception if the required condition isn't met.

Let me know if you have any more issues with this.

ricanteja commented 8 years ago

It's fixed! Great work!