AtomLinter / linter-glsl

Atom package that lints GLSL shaders on the fly.

https://atom.io/packages/linter-glsl

MIT License

15 stars 6 forks source link

[WIP]glslify support #68

Open fand opened 7 years ago

fand commented 7 years ago

It's still experimental. Please give me some advice if you are interested 😸

https://github.com/stackgl/glslify/issues/95

Changes

Added Use glslify to config
Uses forked version of glslify to generate sourcemaps

fand commented 7 years ago

It parses sourcemaps and shows the error line (almost) correctly.

2017-08-16 13 31 55

Arcanemagus commented 7 years ago

This is a very interesting idea, I'm not too sure about moving forward with it here though until support is more baked into the tools behind this.

Thoughts @andystanton?

andystanton commented 6 years ago

@fand @Arcanemagus I think this is a fantastic idea.

As you've already discussed, the sourcemap work needs to be merged in glslify first, but then we can definitely take a look at the best way to integrate it.

I would embrace making glslify linting the default as it will work out of the box, but still give the user the option to use glslangValidator if they prefer to have official Khronos validation.