search

AtomLinter / linter-phpcs

Linter plugin for PHP, using PHP_CodeSniffer.
63 stars 31 forks source link

Using a custom standard causes a syntax error #37

Closed davidbarratt closed 9 years ago

davidbarratt commented 9 years ago

Whenever i use the Drupal Standard: https://www.drupal.org/node/1419988

I have phpcs configured correctly as it executes fine on the command line:

$ phpcs --standard=Drupal /Users/dbarratt/sites/awesomesite/docroot/profiles/standard/modules/custom/some_module/some_module.inc

FILE: some_module.inc
----------------------------------------------------------------------
FOUND 61 ERRORS AND 1 WARNING AFFECTING 32 LINES
----------------------------------------------------------------------
  1 | ERROR   | [x] Missing file doc comment
  1 | ERROR   | [ ] Parameter comment must end with a full stop
  1 | ERROR   | [ ] Parameter comment must end with a full stop
  6 | ERROR   | [x] Doc comment short description must end with a

However, when I set the standard to Drupal in this packages setting and I save the same file, I get this syntax error:

Unexpected token N
SyntaxError: Unexpected token N
  at Object.parse (native)
  at /Users/dbarratt/.atom/packages/linter-phpcs/lib/main.coffee:69:25
  at process._tickCallback (node.js:367:9)
steelbrain commented 9 years ago

I am not sure why would you want to use that output with a module? We use regex or maybe JSON to extract data and we can't adapt our regex according to the input :)

davidbarratt commented 9 years ago

@steelbrain,

I'm not sure I understand what you're saying. linter-phpcs doesn't work when I specify the Drupal standard. All I get is the syntax error in Atom everytime I save a php file. :(

This used to work fine a couple versions ago, I'm not sure what happened. :(

steelbrain commented 9 years ago

Yep, I am able to repro, working on the fix.

steelbrain commented 9 years ago

My error was

PHPCS Response ERROR: the "Drupal" coding standard is not installed. The installed coding standards are MySource, PEAR, PHPCS, PSR1, PSR2, Squiz and Zend

I've added a try/catch now that'll show you a better error message.

davidbarratt commented 9 years ago

@steelbrain,

I've reverted to 0.0.15 and that has fixed the problem, so something changed between the current version and that version that caused the syntax error. :(

davidbarratt commented 9 years ago

whoops that went in late.

yes, you'd have to install the coding standard: https://www.drupal.org/node/1419988#coder

steelbrain commented 9 years ago

Can you repro the error with latest version and post what you see in dev tool's console?

davidbarratt commented 9 years ago

On 1.0.4 I get this:

{"totals":{"errors":241,"warnings":10},"files":{"\/Users\/dbarratt\/sites\/somesite\/docroot\/profiles\/standard\/modules\/custom\/standard_mobile_app_hp_sections\/standard_mobile_app_hp_sections.module":{"errors":241,"warnings":10,"messages":[{"message":"Missing file doc comment","source":"Drupal.Commenting.FileComment.Missing","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must start with a capital letter","source":"Drupal.Commenting.FunctionComment.ParamCommentNotCapital","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must end with a full stop","source":"Drupal.Commenting.FunctionComment.ParamCommentFullStop","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must start with a capital letter","source":"Drupal.Commenting.FunctionComment.ParamCommentNotCapital","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must end with a full stop","source":"Drupal.Commenting.FunctionComment.ParamCommentFullStop","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must start with a capital letter","source":"Drupal.Commenting.FunctionComment.ParamCommentNotCapital","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must end with a full stop","source":"Drupal.Commenting.FunctionComment.ParamCommentFullStop","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must start with a capital letter","source":"Drupal.Commenting.FunctionComment.ParamCommentNotCapital","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must end with a full stop","source":"Drupal.Commenting.FunctionComment.ParamCommentFullStop","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must start with a capital letter","source":"Drupal.Commenting.FunctionComment.ParamCommentNotCapital","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must end with a full stop","source":"Drupal.Commenting.FunctionComment.ParamCommentFullStop","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must start with a capital letter","source":"Drupal.Commenting.FunctionComment.ParamCommentNotCapital","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must end with a full stop","source":"Drupal.Commenting.FunctionComment.ParamCommentFullStop","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must start with a capital letter","source":"Drupal.Commenting.FunctionComment.ParamCommentNotCapital","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must end with a full stop","source":"Drupal.Commenting.FunctionComment.ParamCommentFullStop","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Doc comment short description must end with a full stop","source":"Drupal.Commenting.DocComment.ShortFullStop","severity":5,"type":"ERROR","line":12,"column":4},{"message":"Opening brace should be on the same line as the declaration","source":"Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine","severity":5,"type":"ERROR","line":15,"column":1},{"message":"Line indented incorrectly; expected 4 spaces, found 8","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":18,"column":9},{"message":"Variable \"isEditForm\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":18,"column":9},{"message":"TRUE, FALSE and NULL must be uppercase; expected \"NULL\" but found \"null\"","source":"Generic.PHP.UpperCaseConstant.Found","severity":5,"type":"ERROR","line":18,"column":50},{"message":"Space found before square bracket; expected \"$form[\" but found \"$form [\"","source":"Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket","severity":5,"type":"ERROR","line":20,"column":11},{"message":"Array indentation error, expected 8 spaces but found 10","source":"Drupal.Array.Array.ArrayIndentation","severity":5,"type":"ERROR","line":27,"column":11},{"message":"Array indentation error, expected 8 spaces but found 10","source":"Drupal.Array.Array.ArrayIndentation","severity":5,"type":"ERROR","line":28,"column":11},{"message":"Array indentation error, expected 8 spaces but found 10","source":"Drupal.Array.Array.ArrayIndentation","severity":5,"type":"ERROR","line":29,"column":11},{"message":"A comma should follow the last multiline array item. Found: )","source":"Drupal.Array.Array.CommaLastItem","severity":5,"type":"WARNING","line":30,"column":11},{"message":"Array closing indentation error, expected 6 spaces but found 10","source":"Drupal.Array.Array.ArrayClosingIndentation","severity":5,"type":"ERROR","line":30,"column":11},{"message":"Space found before square bracket; expected \"$form[\" but found \"$form [\"","source":"Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket","severity":5,"type":"ERROR","line":33,"column":11},{"message":"Array closing indentation error, expected 4 spaces but found 6","source":"Drupal.Array.Array.ArrayClosingIndentation","severity":5,"type":"ERROR","line":39,"column":7},{"message":"Line indented incorrectly; expected 4 spaces, found 6","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":41,"column":7},{"message":"Expected 1 space after IF keyword; 0 found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":41,"column":7},{"message":"Variable \"isEditForm\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":41,"column":10},{"message":"There should be no white space before a closing \")\"","source":"Drupal.WhiteSpace.CloseBracketSpacing.ClosingWhitespace","severity":5,"type":"ERROR","line":41,"column":30},{"message":"Expected 1 space after closing parenthesis; found \"\\n      \"","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterCloseParenthesis","severity":5,"type":"ERROR","line":41,"column":31},{"message":"Line indented incorrectly; expected 6 spaces, found 10","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":43,"column":11},{"message":"Variable \"referenceId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":43,"column":11},{"message":"Line indented incorrectly; expected 6 spaces, found 10","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":44,"column":11},{"message":"Variable \"mobileApiHPSections\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":44,"column":11},{"message":"Line indented incorrectly; expected 6 spaces, found 10","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":45,"column":11},{"message":"Variable \"mobileLinkReplace\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":45,"column":11},{"message":"Line indented incorrectly; expected 6 spaces, found 10","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":46,"column":11},{"message":"Variable \"feedItemImageRetrieval\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":46,"column":11},{"message":"Line indented incorrectly; expected 6 spaces, found 10","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":48,"column":11},{"message":"Line indented incorrectly; expected 6 spaces, found 10","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":50,"column":11},{"message":"Variable \"referenceId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":50,"column":15},{"message":"Line indented incorrectly; expected 8 spaces, found 12","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":51,"column":13},{"message":"Variable \"referenceId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":51,"column":28},{"message":"Line indented incorrectly; expected 10 spaces, found 16","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":52,"column":17},{"message":"Variable \"feedItemImageRetrieval\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":52,"column":17},{"message":"Line indented incorrectly; expected 10 spaces, found 16","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":53,"column":17},{"message":"Variable \"referenceId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":53,"column":35},{"message":"Line indented incorrectly; expected 10 spaces, found 16","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":54,"column":17},{"message":"Line indented incorrectly; expected 12 spaces, found 18","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":55,"column":19},{"message":"Variable \"sectionThumbnail\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":55,"column":19},{"message":"Expected 1 space after \"=\"; 2 found","source":"Drupal.WhiteSpace.OperatorSpacing.SpacingAfter","severity":5,"type":"ERROR","line":55,"column":37},{"message":"Variable \"feedItemImageRetrieval\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":55,"column":40},{"message":"Line indented incorrectly; expected 14 spaces, found 16","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":59,"column":17},{"message":"Variable \"sectionThumbnail\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":59,"column":17},{"message":"Expected 1 space after \"=\"; 2 found","source":"Drupal.WhiteSpace.OperatorSpacing.SpacingAfter","severity":5,"type":"ERROR","line":59,"column":35},{"message":"Variable \"mobileApiHPSections\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":59,"column":38},{"message":"Variable \"referenceId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":59,"column":81},{"message":"Expected 1 space after IF keyword; 0 found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":63,"column":11},{"message":"Variable \"sectionThumbnail\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":63,"column":20},{"message":"Expected 1 space after closing parenthesis; found \"\\n          \"","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterCloseParenthesis","severity":5,"type":"ERROR","line":63,"column":38},{"message":"Space found before square bracket; expected \"$form[\" but found \"$form [\"","source":"Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket","severity":5,"type":"ERROR","line":65,"column":19},{"message":"Line indented incorrectly; expected at least 12 spaces, found 10","source":"Drupal.WhiteSpace.ScopeIndent.Incorrect","severity":5,"type":"ERROR","line":66,"column":11},{"message":"Concat operator must be surrounded by a single space","source":"Squiz.Strings.ConcatenationSpacing.PaddingFound","severity":5,"type":"ERROR","line":66,"column":163},{"message":"Variable \"sectionThumbnail\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":66,"column":164},{"message":"Concat operator must be surrounded by a single space","source":"Squiz.Strings.ConcatenationSpacing.PaddingFound","severity":5,"type":"ERROR","line":66,"column":181},{"message":"A comma should follow the last multiline array item. Found: '\" alt=\"Smiley face\" height=\"132\" width=\"228\">'","source":"Drupal.Array.Array.CommaLastItem","severity":5,"type":"WARNING","line":66,"column":182},{"message":"Expected 1 space after ELSE keyword; newline found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":69,"column":11},{"message":"Line indented incorrectly; expected 12 spaces, found 14","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":71,"column":15},{"message":"Space found before square bracket; expected \"$form[\" but found \"$form [\"","source":"Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket","severity":5,"type":"ERROR","line":71,"column":21},{"message":"A comma should follow the last multiline array item. Found: '<a class=\"fieldset-title\" href=\"#\"><span class=\"fieldset-legend-prefix element-invisible\">Hide<\/span>Content Thumbnail<\/a><br\/><p>No thumbnail available<\/p>'","source":"Drupal.Array.Array.CommaLastItem","severity":5,"type":"WARNING","line":72,"column":32},{"message":"Line indented incorrectly; expected 6 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":77,"column":5},{"message":"There should be no white space after an opening \"(\"","source":"Drupal.WhiteSpace.OpenBracketSpacing.OpeningWhitespace","severity":5,"type":"ERROR","line":77,"column":9},{"message":"There should be no white space before a closing \")\"","source":"Drupal.WhiteSpace.CloseBracketSpacing.ClosingWhitespace","severity":5,"type":"ERROR","line":77,"column":50},{"message":"Line indented incorrectly; expected 8 spaces, found 6","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":78,"column":7},{"message":"Variable \"hpSectionQueueId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":82,"column":3},{"message":"Variable \"hpSectionFormId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":83,"column":3},{"message":"Concat operator must be surrounded by a single space","source":"Squiz.Strings.ConcatenationSpacing.PaddingFound","severity":5,"type":"ERROR","line":83,"column":56},{"message":"Variable \"hpSectionQueueId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":83,"column":57},{"message":"Variable \"hpSectionFormId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":84,"column":20},{"message":"Expected 1 space after FOREACH keyword; 0 found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":85,"column":5},{"message":"Expected 1 space after closing parenthesis; found \"\\n    \"","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterCloseParenthesis","severity":5,"type":"ERROR","line":85,"column":45},{"message":"Expected 1 space after IF keyword; 0 found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":87,"column":7},{"message":"Expected 1 space after closing parenthesis; found \"\\n      \"","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterCloseParenthesis","severity":5,"type":"ERROR","line":87,"column":26},{"message":"Variable \"sectionNode\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":89,"column":9},{"message":"Variable \"isEnabled\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":91,"column":9},{"message":"Variable \"sectionNode\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":91,"column":22},{"message":"Variable \"sectionNode\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":91,"column":50},{"message":"Variable \"sectionStatus\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":92,"column":9},{"message":"Expected 1 space after \"=\"; 2 found","source":"Drupal.WhiteSpace.OperatorSpacing.SpacingAfter","severity":5,"type":"ERROR","line":92,"column":24},{"message":"Variable \"isEnabled\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":92,"column":28},{"message":"Variable \"titleMarkup\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":94,"column":9},{"message":"Variable \"innerText\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":95,"column":9},{"message":"Variable \"titleMarkup\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":95,"column":33},{"message":"Variable \"newInnerText\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":96,"column":9},{"message":"Variable \"innerText\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":96,"column":25},{"message":"Concat operator must be surrounded by a single space","source":"Squiz.Strings.ConcatenationSpacing.PaddingFound","severity":5,"type":"ERROR","line":96,"column":35},{"message":"Concat operator must be surrounded by a single space","source":"Squiz.Strings.ConcatenationSpacing.PaddingFound","severity":5,"type":"ERROR","line":96,"column":42},{"message":"Variable \"sectionStatus\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":96,"column":44},{"message":"Concat operator must be surrounded by a single space","source":"Squiz.Strings.ConcatenationSpacing.PaddingFound","severity":5,"type":"ERROR","line":96,"column":58},{"message":"Variable \"myNewString\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":98,"column":9},{"message":"Variable \"innerText\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":98,"column":36},{"message":"Variable \"newInnerText\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":98,"column":48},{"message":"Expected 1 space after comma in function call; 2 found","source":"Generic.Functions.FunctionCallArgumentSpacing.TooMuchSpaceAfterComma","severity":5,"type":"ERROR","line":98,"column":61},{"message":"Expected one space after the comma, 2 found","source":"Drupal.WhiteSpace.Comma.TooManySpaces","severity":5,"type":"ERROR","line":98,"column":61},{"message":"Variable \"titleMarkup\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":98,"column":64},{"message":"Variable \"myNewString\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":99,"column":52},{"message":"Line exceeds 80 characters; contains 88 characters","source":"Drupal.Files.LineLength.TooLong","severity":5,"type":"WARNING","line":106,"column":4},{"message":"Doc comment short description must be on a single line, further text should be a separate paragraph","source":"Drupal.Commenting.DocComment.ShortSingleLine","severity":5,"type":"ERROR","line":107,"column":4},{"message":"Parameter comment must be on the next line","source":"Drupal.Commenting.FunctionComment.ParamCommentNewLine","severity":5,"type":"ERROR","line":109,"column":11},{"message":"Additional blank lines found at end of doc comment","source":"Drupal.Commenting.DocComment.SpacingAfter","severity":5,"type":"ERROR","line":111,"column":2},{"message":"Opening brace should be on the same line as the declaration","source":"Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine","severity":5,"type":"ERROR","line":113,"column":1},{"message":"Line indented incorrectly; expected 2 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":114,"column":5},{"message":"Expected 1 space after IF keyword; 0 found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":114,"column":5},{"message":"Expected 1 space after closing parenthesis; found \"\\n    \"","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterCloseParenthesis","severity":5,"type":"ERROR","line":114,"column":46},{"message":"Line indented incorrectly; expected 4 spaces, found 8","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":116,"column":9},{"message":"Variable \"hpSectionQueueId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":116,"column":9},{"message":"Line indented incorrectly; expected 4 spaces, found 8","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":117,"column":9},{"message":"Variable \"nodeId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":117,"column":9},{"message":"Space found before object operator","source":"Drupal.WhiteSpace.ObjectOperatorSpacing.Before","severity":5,"type":"ERROR","line":117,"column":25},{"message":"Space found after object operator","source":"Drupal.WhiteSpace.ObjectOperatorSpacing.After","severity":5,"type":"ERROR","line":117,"column":25},{"message":"Line indented incorrectly; expected 4 spaces, found 8","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":118,"column":9},{"message":"Variable \"hpSectionQueueId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":118,"column":33},{"message":"Line indented incorrectly; expected 4 spaces, found 8","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":119,"column":9},{"message":"Variable \"hpSectionQueueId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":119,"column":45},{"message":"Line indented incorrectly; expected 4 spaces, found 8","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":120,"column":9},{"message":"Variable \"nodeId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":120,"column":51},{"message":"Line exceeds 80 characters; contains 82 characters","source":"Drupal.Files.LineLength.TooLong","severity":5,"type":"WARNING","line":125,"column":4},{"message":"Doc comment short description must end with a full stop","source":"Drupal.Commenting.DocComment.ShortFullStop","severity":5,"type":"ERROR","line":125,"column":4},{"message":"Parameter comment must be on the next line","source":"Drupal.Commenting.FunctionComment.ParamCommentNewLine","severity":5,"type":"ERROR","line":127,"column":11},{"message":"Parameter comment must be on the next line","source":"Drupal.Commenting.FunctionComment.ParamCommentNewLine","severity":5,"type":"ERROR","line":128,"column":11},{"message":"Separate the @param and @return sections by a blank line.","source":"Drupal.Commenting.DocComment.TagGroupSpacing","severity":5,"type":"ERROR","line":129,"column":4},{"message":"Return comment must be on the next line","source":"Drupal.Commenting.FunctionComment.MissingReturnComment","severity":5,"type":"ERROR","line":129,"column":4},{"message":"Additional blank lines found at end of doc comment","source":"Drupal.Commenting.DocComment.SpacingAfter","severity":5,"type":"ERROR","line":131,"column":2},{"message":"Opening brace should be on the same line as the declaration","source":"Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine","severity":5,"type":"ERROR","line":133,"column":1},{"message":"Line indented incorrectly; expected 2 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":134,"column":5},{"message":"Variable \"mobileLinkReplace\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":134,"column":5},{"message":"Line indented incorrectly; expected 2 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":136,"column":5},{"message":"Variable \"hpItemSection\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":136,"column":5},{"message":"Line indented incorrectly; expected 2 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":137,"column":5},{"message":"Variable \"selectedItemNode\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":137,"column":5},{"message":"No space found before comment text; expected \"\/\/ $form_state['values']['field_node_item'];\" but found \"\/\/$form_state['values']['field_node_item'];\"","source":"Drupal.Commenting.InlineComment.NoSpaceBefore","severity":5,"type":"ERROR","line":137,"column":86},{"message":"Comments may not appear after statements","source":"Squiz.Commenting.PostStatementComment.Found","severity":5,"type":"ERROR","line":137,"column":86},{"message":"Line indented incorrectly; expected 2 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":139,"column":5},{"message":"Variable \"selectedItemNode\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":139,"column":63},{"message":"Line indented incorrectly; expected 2 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":141,"column":5},{"message":"Variable \"selectedItemNodeId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":141,"column":5},{"message":"Line indented incorrectly; expected 2 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":142,"column":5},{"message":"Variable \"itemSection\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":142,"column":5},{"message":"Variable \"hpItemSection\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":142,"column":20},{"message":"Space found before object operator","source":"Drupal.WhiteSpace.ObjectOperatorSpacing.Before","severity":5,"type":"ERROR","line":142,"column":35},{"message":"Variable \"selectedItemNodeId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":142,"column":56},{"message":"Line indented incorrectly; expected 2 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":144,"column":5},{"message":"Expected 1 space after IF keyword; 0 found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":144,"column":5},{"message":"Variable \"itemSection\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":144,"column":14},{"message":"Expected 1 space after closing parenthesis; found \"\\n    \"","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterCloseParenthesis","severity":5,"type":"ERROR","line":144,"column":27},{"message":"Line indented incorrectly; expected 4 spaces, found 8","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":146,"column":9},{"message":"Line indented incorrectly; expected 4 spaces, found 8","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":147,"column":9},{"message":"Line indented incorrectly; expected 4 spaces, found 8","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":149,"column":9},{"message":"Variable \"itemSection\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":149,"column":36},{"message":"Space found before object operator","source":"Drupal.WhiteSpace.ObjectOperatorSpacing.Before","severity":5,"type":"ERROR","line":149,"column":49},{"message":"Space found after object operator","source":"Drupal.WhiteSpace.ObjectOperatorSpacing.After","severity":5,"type":"ERROR","line":149,"column":49},{"message":"Line indented incorrectly; expected 4 spaces, found 8","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":150,"column":9},{"message":"Variable \"itemSection\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":150,"column":60},{"message":"Space found before object operator","source":"Drupal.WhiteSpace.ObjectOperatorSpacing.Before","severity":5,"type":"ERROR","line":150,"column":73},{"message":"Space found after object operator","source":"Drupal.WhiteSpace.ObjectOperatorSpacing.After","severity":5,"type":"ERROR","line":150,"column":73},{"message":"Line indented incorrectly; expected 4 spaces, found 8","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":151,"column":9},{"message":"Variable \"itemSection\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":151,"column":72},{"message":"Space found before object operator","source":"Drupal.WhiteSpace.ObjectOperatorSpacing.Before","severity":5,"type":"ERROR","line":151,"column":85},{"message":"Space found after object operator","source":"Drupal.WhiteSpace.ObjectOperatorSpacing.After","severity":5,"type":"ERROR","line":151,"column":85},{"message":"Line indented incorrectly; expected 4 spaces, found 8","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":153,"column":9},{"message":"Expected 1 space after IF keyword; 0 found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":153,"column":9},{"message":"Variable \"itemSection\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":153,"column":18},{"message":"Expected 1 space after closing parenthesis; found \"\\n        \"","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterCloseParenthesis","severity":5,"type":"ERROR","line":153,"column":41},{"message":"Line indented incorrectly; expected 6 spaces, found 12","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":155,"column":13},{"message":"Space found before square bracket; expected \"$form[\" but found \"$form [\"","source":"Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket","severity":5,"type":"ERROR","line":155,"column":19},{"message":"Concat operator must be surrounded by a single space","source":"Squiz.Strings.ConcatenationSpacing.PaddingFound","severity":5,"type":"ERROR","line":156,"column":161},{"message":"Variable \"itemSection\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":156,"column":162},{"message":"Concat operator must be surrounded by a single space","source":"Squiz.Strings.ConcatenationSpacing.PaddingFound","severity":5,"type":"ERROR","line":156,"column":184},{"message":"A comma should follow the last multiline array item. Found: '\" alt=\"Smiley face\" height=\"132\" width=\"228\">'","source":"Drupal.Array.Array.CommaLastItem","severity":5,"type":"WARNING","line":156,"column":185},{"message":"Expected 1 space after ELSE keyword; newline found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":159,"column":9},{"message":"Line indented incorrectly; expected 10 spaces, found 12","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":161,"column":13},{"message":"Space found before square bracket; expected \"$form[\" but found \"$form [\"","source":"Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket","severity":5,"type":"ERROR","line":161,"column":19},{"message":"A comma should follow the last multiline array item. Found: '<a class=\"fieldset-title\" href=\"#\"><span class=\"fieldset-legend-prefix element-invisible\">Hide<\/span>Content Thumbnail<\/a><br\/><p>No thumbnail available<\/p>'","source":"Drupal.Array.Array.CommaLastItem","severity":5,"type":"WARNING","line":162,"column":28},{"message":"Variable \"selectedItemNodeId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":166,"column":71},{"message":"Line exceeds 80 characters; contains 84 characters","source":"Drupal.Files.LineLength.TooLong","severity":5,"type":"WARNING","line":175,"column":4},{"message":"Doc comment short description must end with a full stop","source":"Drupal.Commenting.DocComment.ShortFullStop","severity":5,"type":"ERROR","line":175,"column":4},{"message":"Parameter comment must be on the next line","source":"Drupal.Commenting.FunctionComment.ParamCommentNewLine","severity":5,"type":"ERROR","line":177,"column":11},{"message":"Parameter comment must be on the next line","source":"Drupal.Commenting.FunctionComment.ParamCommentNewLine","severity":5,"type":"ERROR","line":178,"column":11},{"message":"Separate the @param and @return sections by a blank line.","source":"Drupal.Commenting.DocComment.TagGroupSpacing","severity":5,"type":"ERROR","line":179,"column":4},{"message":"Return comment must be on the next line","source":"Drupal.Commenting.FunctionComment.MissingReturnComment","severity":5,"type":"ERROR","line":179,"column":4},{"message":"Additional blank lines found at end of doc comment","source":"Drupal.Commenting.DocComment.SpacingAfter","severity":5,"type":"ERROR","line":181,"column":2},{"message":"Opening brace should be on the same line as the declaration","source":"Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine","severity":5,"type":"ERROR","line":183,"column":1},{"message":"Line indented incorrectly; expected 2 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":184,"column":5},{"message":"Variable \"mobileLinkReplace\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":184,"column":5},{"message":"Line indented incorrectly; expected 2 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":185,"column":5},{"message":"Variable \"hpItemSection\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":185,"column":5},{"message":"Line indented incorrectly; expected 2 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":186,"column":5},{"message":"Variable \"mobileApiHPSections\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":186,"column":5},{"message":"Line indented incorrectly; expected 2 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":188,"column":5},{"message":"Variable \"feedId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":188,"column":5},{"message":"Line indented incorrectly; expected 2 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":189,"column":5},{"message":"Expected 1 space after IF keyword; 0 found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":189,"column":5},{"message":"Variable \"feedId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":189,"column":14},{"message":"Expected 1 space after closing parenthesis; found \"\\n    \"","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterCloseParenthesis","severity":5,"type":"ERROR","line":189,"column":22},{"message":"Variable \"feedReferenceId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":192,"column":5},{"message":"Variable \"hpItemSection\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":192,"column":24},{"message":"Variable \"feedId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":192,"column":64},{"message":"Expected 1 space after IF keyword; 0 found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":194,"column":5},{"message":"Variable \"feedReferenceId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":194,"column":14},{"message":"Variable \"feedReferenceId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":194,"column":35},{"message":"Expected 1 space after closing parenthesis; found \"\\n    \"","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterCloseParenthesis","severity":5,"type":"ERROR","line":194,"column":57},{"message":"Variable \"feedReferenceId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":196,"column":11},{"message":"Expected 1 space after closing parenthesis; found \"\\n      \"","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterCloseParenthesis","severity":5,"type":"ERROR","line":196,"column":48},{"message":"Variable \"mobileUrl\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":198,"column":9},{"message":"Variable \"mobileLinkReplace\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":198,"column":22},{"message":"Expected 1 space after ELSE keyword; newline found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":200,"column":7},{"message":"Variable \"mobileUrl\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":202,"column":9},{"message":"Variable \"mobileLinkReplace\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":202,"column":22},{"message":"Variable \"feedReferenceId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":202,"column":64},{"message":"Variable \"feedId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":208,"column":130},{"message":"Variable \"mobileUrl\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":209,"column":58},{"message":"Variable \"feedReferenceId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":210,"column":69},{"message":"Variable \"sectionThumbnail\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":212,"column":7},{"message":"Variable \"mobileApiHPSections\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":212,"column":27},{"message":"Variable \"feedReferenceId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":212,"column":70},{"message":"Expected 1 space after IF keyword; 0 found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":214,"column":7},{"message":"Variable \"sectionThumbnail\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":214,"column":16},{"message":"Expected 1 space after closing parenthesis; found \"\\n      \"","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterCloseParenthesis","severity":5,"type":"ERROR","line":214,"column":34},{"message":"Space found before square bracket; expected \"$form[\" but found \"$form [\"","source":"Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket","severity":5,"type":"ERROR","line":216,"column":15},{"message":"Concat operator must be surrounded by a single space","source":"Squiz.Strings.ConcatenationSpacing.PaddingFound","severity":5,"type":"ERROR","line":217,"column":163},{"message":"Variable \"sectionThumbnail\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":217,"column":164},{"message":"Concat operator must be surrounded by a single space","source":"Squiz.Strings.ConcatenationSpacing.PaddingFound","severity":5,"type":"ERROR","line":217,"column":181},{"message":"A comma should follow the last multiline array item. Found: '\" alt=\"Smiley face\" height=\"132\" width=\"228\">'","source":"Drupal.Array.Array.CommaLastItem","severity":5,"type":"WARNING","line":217,"column":182},{"message":"Expected 1 space after ELSE keyword; newline found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":220,"column":7},{"message":"Line indented incorrectly; expected 8 spaces, found 10","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":222,"column":11},{"message":"Space found before square bracket; expected \"$form[\" but found \"$form [\"","source":"Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket","severity":5,"type":"ERROR","line":222,"column":17},{"message":"A comma should follow the last multiline array item. Found: '<a class=\"fieldset-title\" href=\"#\"><span class=\"fieldset-legend-prefix element-invisible\">Hide<\/span>Content Thumbnail<\/a><br\/><p>No thumbnail available<\/p>'","source":"Drupal.Array.Array.CommaLastItem","severity":5,"type":"WARNING","line":223,"column":24},{"message":"Line indented incorrectly; expected 4 spaces, found 2","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":227,"column":3},{"message":"Closing brace indented incorrectly; expected 4 spaces, found 2","source":"Drupal.WhiteSpace.ScopeClosingBrace.Indent","severity":5,"type":"ERROR","line":227,"column":3},{"message":"Doc comment short description must start with a capital letter","source":"Drupal.Commenting.DocComment.ShortNotCapital","severity":5,"type":"ERROR","line":232,"column":4},{"message":"Doc comment short description must end with a full stop","source":"Drupal.Commenting.DocComment.ShortFullStop","severity":5,"type":"ERROR","line":232,"column":4},{"message":"Parameter comment must be on the next line","source":"Drupal.Commenting.FunctionComment.ParamCommentNewLine","severity":5,"type":"ERROR","line":234,"column":11},{"message":"Parameter comment must be on the next line","source":"Drupal.Commenting.FunctionComment.ParamCommentNewLine","severity":5,"type":"ERROR","line":235,"column":11},{"message":"Separate the @param and @return sections by a blank line.","source":"Drupal.Commenting.DocComment.TagGroupSpacing","severity":5,"type":"ERROR","line":236,"column":4},{"message":"Return comment must be on the next line","source":"Drupal.Commenting.FunctionComment.MissingReturnComment","severity":5,"type":"ERROR","line":236,"column":4},{"message":"Additional blank lines found at end of doc comment","source":"Drupal.Commenting.DocComment.SpacingAfter","severity":5,"type":"ERROR","line":238,"column":2},{"message":"Line indented incorrectly; expected 2 spaces, found 0","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":240,"column":1},{"message":"Line indented incorrectly; expected 2 spaces, found 0","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":241,"column":1}]}}}

I don't get any errors, but Linter is also reporting 0 problems with the file.

davidbarratt commented 9 years ago

@steelbrain,

If I change phpcs to be the one in my repo, I get this error:

PHPCS Response 
Fatal error: Uncaught exception 'UnexpectedValueException' with message 'DirectoryIterator::__construct(vendor/drupal/coder/coder_sniffer): failed to open dir: No such file or directory' in /Users/dbarratt/sites/golfchannel/vendor/squizlabs/php_codesniffer/CodeSniffer.php:2153
Stack trace:
#0 /Users/dbarratt/sites/somesite/vendor/squizlabs/php_codesniffer/CodeSniffer.php(2153): DirectoryIterator->__construct('vendor/drupal/c...')
#1 /Users/dbarratt/sites/somesite/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php(1032): PHP_CodeSniffer::getInstalledStandards()
#2 /Users/dbarratt/sites/somesite/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php(809): PHP_CodeSniffer_CLI->validateStandard(Array)
#3 /Users/dbarratt/sites/somesite/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php(95): PHP_CodeSniffer_CLI->process()
#4 /Users/dbarratt/sites/somesite/vendor/squizlabs/php_codesniffer/scripts/phpcs(25): PHP_CodeSniffer_CLI->runphpcs()
#5 {main}
  thrown in /Users/dbarratt/sites/somesite/vendor/squizlabs/php_codesniffer/CodeSniffer.php on line 2153
steelbrain commented 9 years ago

That's actually a PHPCS error, not a bug in the package.

davidbarratt commented 9 years ago

Here's my CodeSniffer.conf

<?php
 $phpCodeSnifferConfig = array (
  'installed_paths' => 'vendor/drupal/coder/coder_sniffer',
)
?>

I think the problem is the relative path of the Config... ?

steelbrain commented 9 years ago

I am not much experienced with CodeSniffer :sweat_smile: I use facebook's hacklang and their top-notch hh_client aka typechecker.

davidbarratt commented 9 years ago

ooo...

yeah here is my phpcs config:

    codeStandardOrConfigFile: "Drupal"
    executablePath: "/Users/dbarratt/sites/golfchannel/vendor/bin/phpcs"

so it looks like linter-phpcs freaks out when one of phpcs' config is relative. :(

steelbrain commented 9 years ago

Maybe :)

davidbarratt commented 9 years ago

When I change it to an absolute path, I get back to this error:

PHPCS Response 
Notice: Undefined offset: 0 in /Users/dbarratt/sites/somesite/vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Commenting/FunctionCommentSniff.php on line 665

Notice: Undefined offset: 0 in /Users/dbarratt/sites/somesite/vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Commenting/FunctionCommentSniff.php on line 665

Notice: Undefined offset: 0 in /Users/dbarratt/sites/somesite/vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Commenting/FunctionCommentSniff.php on line 665

Notice: Undefined offset: 0 in /Users/dbarratt/sites/somesite/vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Commenting/FunctionCommentSniff.php on line 665

Notice: Undefined offset: 0 in /Users/dbarratt/sites/somesite/vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Commenting/FunctionCommentSniff.php on line 665

Notice: Undefined offset: 0 in /Users/dbarratt/sites/somesite/vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Commenting/FunctionCommentSniff.php on line 665

Notice: Undefined offset: 0 in /Users/dbarratt/sites/somesite/vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Commenting/FunctionCommentSniff.php on line 665
{"totals":{"errors":241,"warnings":10},"files":{"\/Users\/dbarratt\/sites\/somesite\/docroot\/profiles\/standard\/modules\/custom\/some_mobile_app_hp_sections\/some_mobile_app_hp_sections.module":{"errors":241,"warnings":10,"messages":[{"message":"Missing file doc comment","source":"Drupal.Commenting.FileComment.Missing","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must start with a capital letter","source":"Drupal.Commenting.FunctionComment.ParamCommentNotCapital","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must end with a full stop","source":"Drupal.Commenting.FunctionComment.ParamCommentFullStop","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must start with a capital letter","source":"Drupal.Commenting.FunctionComment.ParamCommentNotCapital","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must end with a full stop","source":"Drupal.Commenting.FunctionComment.ParamCommentFullStop","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must start with a capital letter","source":"Drupal.Commenting.FunctionComment.ParamCommentNotCapital","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must end with a full stop","source":"Drupal.Commenting.FunctionComment.ParamCommentFullStop","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must start with a capital letter","source":"Drupal.Commenting.FunctionComment.ParamCommentNotCapital","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must end with a full stop","source":"Drupal.Commenting.FunctionComment.ParamCommentFullStop","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must start with a capital letter","source":"Drupal.Commenting.FunctionComment.ParamCommentNotCapital","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must end with a full stop","source":"Drupal.Commenting.FunctionComment.ParamCommentFullStop","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must start with a capital letter","source":"Drupal.Commenting.FunctionComment.ParamCommentNotCapital","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must end with a full stop","source":"Drupal.Commenting.FunctionComment.ParamCommentFullStop","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must start with a capital letter","source":"Drupal.Commenting.FunctionComment.ParamCommentNotCapital","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Parameter comment must end with a full stop","source":"Drupal.Commenting.FunctionComment.ParamCommentFullStop","severity":5,"type":"ERROR","line":1,"column":1},{"message":"Doc comment short description must end with a full stop","source":"Drupal.Commenting.DocComment.ShortFullStop","severity":5,"type":"ERROR","line":12,"column":4},{"message":"Opening brace should be on the same line as the declaration","source":"Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine","severity":5,"type":"ERROR","line":15,"column":1},{"message":"Line indented incorrectly; expected 4 spaces, found 8","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":18,"column":9},{"message":"Variable \"isEditForm\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":18,"column":9},{"message":"TRUE, FALSE and NULL must be uppercase; expected \"NULL\" but found \"null\"","source":"Generic.PHP.UpperCaseConstant.Found","severity":5,"type":"ERROR","line":18,"column":50},{"message":"Space found before square bracket; expected \"$form[\" but found \"$form [\"","source":"Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket","severity":5,"type":"ERROR","line":20,"column":11},{"message":"Array indentation error, expected 8 spaces but found 10","source":"Drupal.Array.Array.ArrayIndentation","severity":5,"type":"ERROR","line":27,"column":11},{"message":"Array indentation error, expected 8 spaces but found 10","source":"Drupal.Array.Array.ArrayIndentation","severity":5,"type":"ERROR","line":28,"column":11},{"message":"Array indentation error, expected 8 spaces but found 10","source":"Drupal.Array.Array.ArrayIndentation","severity":5,"type":"ERROR","line":29,"column":11},{"message":"A comma should follow the last multiline array item. Found: )","source":"Drupal.Array.Array.CommaLastItem","severity":5,"type":"WARNING","line":30,"column":11},{"message":"Array closing indentation error, expected 6 spaces but found 10","source":"Drupal.Array.Array.ArrayClosingIndentation","severity":5,"type":"ERROR","line":30,"column":11},{"message":"Space found before square bracket; expected \"$form[\" but found \"$form [\"","source":"Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket","severity":5,"type":"ERROR","line":33,"column":11},{"message":"Array closing indentation error, expected 4 spaces but found 6","source":"Drupal.Array.Array.ArrayClosingIndentation","severity":5,"type":"ERROR","line":39,"column":7},{"message":"Line indented incorrectly; expected 4 spaces, found 6","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":41,"column":7},{"message":"Expected 1 space after IF keyword; 0 found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":41,"column":7},{"message":"Variable \"isEditForm\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":41,"column":10},{"message":"There should be no white space before a closing \")\"","source":"Drupal.WhiteSpace.CloseBracketSpacing.ClosingWhitespace","severity":5,"type":"ERROR","line":41,"column":30},{"message":"Expected 1 space after closing parenthesis; found \"\\n      \"","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterCloseParenthesis","severity":5,"type":"ERROR","line":41,"column":31},{"message":"Line indented incorrectly; expected 6 spaces, found 10","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":43,"column":11},{"message":"Variable \"referenceId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":43,"column":11},{"message":"Line indented incorrectly; expected 6 spaces, found 10","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":44,"column":11},{"message":"Variable \"mobileApiHPSections\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":44,"column":11},{"message":"Line indented incorrectly; expected 6 spaces, found 10","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":45,"column":11},{"message":"Variable \"mobileLinkReplace\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":45,"column":11},{"message":"Line indented incorrectly; expected 6 spaces, found 10","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":46,"column":11},{"message":"Variable \"feedItemImageRetrieval\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":46,"column":11},{"message":"Line indented incorrectly; expected 6 spaces, found 10","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":48,"column":11},{"message":"Line indented incorrectly; expected 6 spaces, found 10","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":50,"column":11},{"message":"Variable \"referenceId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":50,"column":15},{"message":"Line indented incorrectly; expected 8 spaces, found 12","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":51,"column":13},{"message":"Variable \"referenceId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":51,"column":28},{"message":"Line indented incorrectly; expected 10 spaces, found 16","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":52,"column":17},{"message":"Variable \"feedItemImageRetrieval\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":52,"column":17},{"message":"Line indented incorrectly; expected 10 spaces, found 16","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":53,"column":17},{"message":"Variable \"referenceId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":53,"column":35},{"message":"Line indented incorrectly; expected 10 spaces, found 16","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":54,"column":17},{"message":"Line indented incorrectly; expected 12 spaces, found 18","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":55,"column":19},{"message":"Variable \"sectionThumbnail\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":55,"column":19},{"message":"Expected 1 space after \"=\"; 2 found","source":"Drupal.WhiteSpace.OperatorSpacing.SpacingAfter","severity":5,"type":"ERROR","line":55,"column":37},{"message":"Variable \"feedItemImageRetrieval\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":55,"column":40},{"message":"Line indented incorrectly; expected 14 spaces, found 16","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":59,"column":17},{"message":"Variable \"sectionThumbnail\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":59,"column":17},{"message":"Expected 1 space after \"=\"; 2 found","source":"Drupal.WhiteSpace.OperatorSpacing.SpacingAfter","severity":5,"type":"ERROR","line":59,"column":35},{"message":"Variable \"mobileApiHPSections\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":59,"column":38},{"message":"Variable \"referenceId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":59,"column":81},{"message":"Expected 1 space after IF keyword; 0 found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":63,"column":11},{"message":"Variable \"sectionThumbnail\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":63,"column":20},{"message":"Expected 1 space after closing parenthesis; found \"\\n          \"","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterCloseParenthesis","severity":5,"type":"ERROR","line":63,"column":38},{"message":"Space found before square bracket; expected \"$form[\" but found \"$form [\"","source":"Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket","severity":5,"type":"ERROR","line":65,"column":19},{"message":"Line indented incorrectly; expected at least 12 spaces, found 10","source":"Drupal.WhiteSpace.ScopeIndent.Incorrect","severity":5,"type":"ERROR","line":66,"column":11},{"message":"Concat operator must be surrounded by a single space","source":"Squiz.Strings.ConcatenationSpacing.PaddingFound","severity":5,"type":"ERROR","line":66,"column":163},{"message":"Variable \"sectionThumbnail\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":66,"column":164},{"message":"Concat operator must be surrounded by a single space","source":"Squiz.Strings.ConcatenationSpacing.PaddingFound","severity":5,"type":"ERROR","line":66,"column":181},{"message":"A comma should follow the last multiline array item. Found: '\" alt=\"Smiley face\" height=\"132\" width=\"228\">'","source":"Drupal.Array.Array.CommaLastItem","severity":5,"type":"WARNING","line":66,"column":182},{"message":"Expected 1 space after ELSE keyword; newline found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":69,"column":11},{"message":"Line indented incorrectly; expected 12 spaces, found 14","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":71,"column":15},{"message":"Space found before square bracket; expected \"$form[\" but found \"$form [\"","source":"Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket","severity":5,"type":"ERROR","line":71,"column":21},{"message":"A comma should follow the last multiline array item. Found: '<a class=\"fieldset-title\" href=\"#\"><span class=\"fieldset-legend-prefix element-invisible\">Hide<\/span>Content Thumbnail<\/a><br\/><p>No thumbnail available<\/p>'","source":"Drupal.Array.Array.CommaLastItem","severity":5,"type":"WARNING","line":72,"column":32},{"message":"Line indented incorrectly; expected 6 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":77,"column":5},{"message":"There should be no white space after an opening \"(\"","source":"Drupal.WhiteSpace.OpenBracketSpacing.OpeningWhitespace","severity":5,"type":"ERROR","line":77,"column":9},{"message":"There should be no white space before a closing \")\"","source":"Drupal.WhiteSpace.CloseBracketSpacing.ClosingWhitespace","severity":5,"type":"ERROR","line":77,"column":50},{"message":"Line indented incorrectly; expected 8 spaces, found 6","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":78,"column":7},{"message":"Variable \"hpSectionQueueId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":82,"column":3},{"message":"Variable \"hpSectionFormId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":83,"column":3},{"message":"Concat operator must be surrounded by a single space","source":"Squiz.Strings.ConcatenationSpacing.PaddingFound","severity":5,"type":"ERROR","line":83,"column":56},{"message":"Variable \"hpSectionQueueId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":83,"column":57},{"message":"Variable \"hpSectionFormId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":84,"column":20},{"message":"Expected 1 space after FOREACH keyword; 0 found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":85,"column":5},{"message":"Expected 1 space after closing parenthesis; found \"\\n    \"","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterCloseParenthesis","severity":5,"type":"ERROR","line":85,"column":45},{"message":"Expected 1 space after IF keyword; 0 found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":87,"column":7},{"message":"Expected 1 space after closing parenthesis; found \"\\n      \"","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterCloseParenthesis","severity":5,"type":"ERROR","line":87,"column":26},{"message":"Variable \"sectionNode\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":89,"column":9},{"message":"Variable \"isEnabled\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":91,"column":9},{"message":"Variable \"sectionNode\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":91,"column":22},{"message":"Variable \"sectionNode\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":91,"column":50},{"message":"Variable \"sectionStatus\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":92,"column":9},{"message":"Expected 1 space after \"=\"; 2 found","source":"Drupal.WhiteSpace.OperatorSpacing.SpacingAfter","severity":5,"type":"ERROR","line":92,"column":24},{"message":"Variable \"isEnabled\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":92,"column":28},{"message":"Variable \"titleMarkup\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":94,"column":9},{"message":"Variable \"innerText\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":95,"column":9},{"message":"Variable \"titleMarkup\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":95,"column":33},{"message":"Variable \"newInnerText\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":96,"column":9},{"message":"Variable \"innerText\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":96,"column":25},{"message":"Concat operator must be surrounded by a single space","source":"Squiz.Strings.ConcatenationSpacing.PaddingFound","severity":5,"type":"ERROR","line":96,"column":35},{"message":"Concat operator must be surrounded by a single space","source":"Squiz.Strings.ConcatenationSpacing.PaddingFound","severity":5,"type":"ERROR","line":96,"column":42},{"message":"Variable \"sectionStatus\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":96,"column":44},{"message":"Concat operator must be surrounded by a single space","source":"Squiz.Strings.ConcatenationSpacing.PaddingFound","severity":5,"type":"ERROR","line":96,"column":58},{"message":"Variable \"myNewString\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":98,"column":9},{"message":"Variable \"innerText\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":98,"column":36},{"message":"Variable \"newInnerText\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":98,"column":48},{"message":"Expected 1 space after comma in function call; 2 found","source":"Generic.Functions.FunctionCallArgumentSpacing.TooMuchSpaceAfterComma","severity":5,"type":"ERROR","line":98,"column":61},{"message":"Expected one space after the comma, 2 found","source":"Drupal.WhiteSpace.Comma.TooManySpaces","severity":5,"type":"ERROR","line":98,"column":61},{"message":"Variable \"titleMarkup\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":98,"column":64},{"message":"Variable \"myNewString\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":99,"column":52},{"message":"Line exceeds 80 characters; contains 88 characters","source":"Drupal.Files.LineLength.TooLong","severity":5,"type":"WARNING","line":106,"column":4},{"message":"Doc comment short description must be on a single line, further text should be a separate paragraph","source":"Drupal.Commenting.DocComment.ShortSingleLine","severity":5,"type":"ERROR","line":107,"column":4},{"message":"Parameter comment must be on the next line","source":"Drupal.Commenting.FunctionComment.ParamCommentNewLine","severity":5,"type":"ERROR","line":109,"column":11},{"message":"Additional blank lines found at end of doc comment","source":"Drupal.Commenting.DocComment.SpacingAfter","severity":5,"type":"ERROR","line":111,"column":2},{"message":"Opening brace should be on the same line as the declaration","source":"Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine","severity":5,"type":"ERROR","line":113,"column":1},{"message":"Line indented incorrectly; expected 2 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":114,"column":5},{"message":"Expected 1 space after IF keyword; 0 found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":114,"column":5},{"message":"Expected 1 space after closing parenthesis; found \"\\n    \"","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterCloseParenthesis","severity":5,"type":"ERROR","line":114,"column":46},{"message":"Line indented incorrectly; expected 4 spaces, found 8","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":116,"column":9},{"message":"Variable \"hpSectionQueueId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":116,"column":9},{"message":"Line indented incorrectly; expected 4 spaces, found 8","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":117,"column":9},{"message":"Variable \"nodeId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":117,"column":9},{"message":"Space found before object operator","source":"Drupal.WhiteSpace.ObjectOperatorSpacing.Before","severity":5,"type":"ERROR","line":117,"column":25},{"message":"Space found after object operator","source":"Drupal.WhiteSpace.ObjectOperatorSpacing.After","severity":5,"type":"ERROR","line":117,"column":25},{"message":"Line indented incorrectly; expected 4 spaces, found 8","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":118,"column":9},{"message":"Variable \"hpSectionQueueId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":118,"column":33},{"message":"Line indented incorrectly; expected 4 spaces, found 8","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":119,"column":9},{"message":"Variable \"hpSectionQueueId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":119,"column":45},{"message":"Line indented incorrectly; expected 4 spaces, found 8","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":120,"column":9},{"message":"Variable \"nodeId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":120,"column":51},{"message":"Line exceeds 80 characters; contains 82 characters","source":"Drupal.Files.LineLength.TooLong","severity":5,"type":"WARNING","line":125,"column":4},{"message":"Doc comment short description must end with a full stop","source":"Drupal.Commenting.DocComment.ShortFullStop","severity":5,"type":"ERROR","line":125,"column":4},{"message":"Parameter comment must be on the next line","source":"Drupal.Commenting.FunctionComment.ParamCommentNewLine","severity":5,"type":"ERROR","line":127,"column":11},{"message":"Parameter comment must be on the next line","source":"Drupal.Commenting.FunctionComment.ParamCommentNewLine","severity":5,"type":"ERROR","line":128,"column":11},{"message":"Separate the @param and @return sections by a blank line.","source":"Drupal.Commenting.DocComment.TagGroupSpacing","severity":5,"type":"ERROR","line":129,"column":4},{"message":"Return comment must be on the next line","source":"Drupal.Commenting.FunctionComment.MissingReturnComment","severity":5,"type":"ERROR","line":129,"column":4},{"message":"Additional blank lines found at end of doc comment","source":"Drupal.Commenting.DocComment.SpacingAfter","severity":5,"type":"ERROR","line":131,"column":2},{"message":"Opening brace should be on the same line as the declaration","source":"Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine","severity":5,"type":"ERROR","line":133,"column":1},{"message":"Line indented incorrectly; expected 2 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":134,"column":5},{"message":"Variable \"mobileLinkReplace\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":134,"column":5},{"message":"Line indented incorrectly; expected 2 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":136,"column":5},{"message":"Variable \"hpItemSection\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":136,"column":5},{"message":"Line indented incorrectly; expected 2 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":137,"column":5},{"message":"Variable \"selectedItemNode\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":137,"column":5},{"message":"No space found before comment text; expected \"\/\/ $form_state['values']['field_node_item'];\" but found \"\/\/$form_state['values']['field_node_item'];\"","source":"Drupal.Commenting.InlineComment.NoSpaceBefore","severity":5,"type":"ERROR","line":137,"column":86},{"message":"Comments may not appear after statements","source":"Squiz.Commenting.PostStatementComment.Found","severity":5,"type":"ERROR","line":137,"column":86},{"message":"Line indented incorrectly; expected 2 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":139,"column":5},{"message":"Variable \"selectedItemNode\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":139,"column":63},{"message":"Line indented incorrectly; expected 2 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":141,"column":5},{"message":"Variable \"selectedItemNodeId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":141,"column":5},{"message":"Line indented incorrectly; expected 2 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":142,"column":5},{"message":"Variable \"itemSection\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":142,"column":5},{"message":"Variable \"hpItemSection\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":142,"column":20},{"message":"Space found before object operator","source":"Drupal.WhiteSpace.ObjectOperatorSpacing.Before","severity":5,"type":"ERROR","line":142,"column":35},{"message":"Variable \"selectedItemNodeId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":142,"column":56},{"message":"Line indented incorrectly; expected 2 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":144,"column":5},{"message":"Expected 1 space after IF keyword; 0 found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":144,"column":5},{"message":"Variable \"itemSection\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":144,"column":14},{"message":"Expected 1 space after closing parenthesis; found \"\\n    \"","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterCloseParenthesis","severity":5,"type":"ERROR","line":144,"column":27},{"message":"Line indented incorrectly; expected 4 spaces, found 8","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":146,"column":9},{"message":"Line indented incorrectly; expected 4 spaces, found 8","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":147,"column":9},{"message":"Line indented incorrectly; expected 4 spaces, found 8","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":149,"column":9},{"message":"Variable \"itemSection\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":149,"column":36},{"message":"Space found before object operator","source":"Drupal.WhiteSpace.ObjectOperatorSpacing.Before","severity":5,"type":"ERROR","line":149,"column":49},{"message":"Space found after object operator","source":"Drupal.WhiteSpace.ObjectOperatorSpacing.After","severity":5,"type":"ERROR","line":149,"column":49},{"message":"Line indented incorrectly; expected 4 spaces, found 8","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":150,"column":9},{"message":"Variable \"itemSection\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":150,"column":60},{"message":"Space found before object operator","source":"Drupal.WhiteSpace.ObjectOperatorSpacing.Before","severity":5,"type":"ERROR","line":150,"column":73},{"message":"Space found after object operator","source":"Drupal.WhiteSpace.ObjectOperatorSpacing.After","severity":5,"type":"ERROR","line":150,"column":73},{"message":"Line indented incorrectly; expected 4 spaces, found 8","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":151,"column":9},{"message":"Variable \"itemSection\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":151,"column":72},{"message":"Space found before object operator","source":"Drupal.WhiteSpace.ObjectOperatorSpacing.Before","severity":5,"type":"ERROR","line":151,"column":85},{"message":"Space found after object operator","source":"Drupal.WhiteSpace.ObjectOperatorSpacing.After","severity":5,"type":"ERROR","line":151,"column":85},{"message":"Line indented incorrectly; expected 4 spaces, found 8","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":153,"column":9},{"message":"Expected 1 space after IF keyword; 0 found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":153,"column":9},{"message":"Variable \"itemSection\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":153,"column":18},{"message":"Expected 1 space after closing parenthesis; found \"\\n        \"","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterCloseParenthesis","severity":5,"type":"ERROR","line":153,"column":41},{"message":"Line indented incorrectly; expected 6 spaces, found 12","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":155,"column":13},{"message":"Space found before square bracket; expected \"$form[\" but found \"$form [\"","source":"Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket","severity":5,"type":"ERROR","line":155,"column":19},{"message":"Concat operator must be surrounded by a single space","source":"Squiz.Strings.ConcatenationSpacing.PaddingFound","severity":5,"type":"ERROR","line":156,"column":161},{"message":"Variable \"itemSection\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":156,"column":162},{"message":"Concat operator must be surrounded by a single space","source":"Squiz.Strings.ConcatenationSpacing.PaddingFound","severity":5,"type":"ERROR","line":156,"column":184},{"message":"A comma should follow the last multiline array item. Found: '\" alt=\"Smiley face\" height=\"132\" width=\"228\">'","source":"Drupal.Array.Array.CommaLastItem","severity":5,"type":"WARNING","line":156,"column":185},{"message":"Expected 1 space after ELSE keyword; newline found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":159,"column":9},{"message":"Line indented incorrectly; expected 10 spaces, found 12","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":161,"column":13},{"message":"Space found before square bracket; expected \"$form[\" but found \"$form [\"","source":"Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket","severity":5,"type":"ERROR","line":161,"column":19},{"message":"A comma should follow the last multiline array item. Found: '<a class=\"fieldset-title\" href=\"#\"><span class=\"fieldset-legend-prefix element-invisible\">Hide<\/span>Content Thumbnail<\/a><br\/><p>No thumbnail available<\/p>'","source":"Drupal.Array.Array.CommaLastItem","severity":5,"type":"WARNING","line":162,"column":28},{"message":"Variable \"selectedItemNodeId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":166,"column":71},{"message":"Line exceeds 80 characters; contains 84 characters","source":"Drupal.Files.LineLength.TooLong","severity":5,"type":"WARNING","line":175,"column":4},{"message":"Doc comment short description must end with a full stop","source":"Drupal.Commenting.DocComment.ShortFullStop","severity":5,"type":"ERROR","line":175,"column":4},{"message":"Parameter comment must be on the next line","source":"Drupal.Commenting.FunctionComment.ParamCommentNewLine","severity":5,"type":"ERROR","line":177,"column":11},{"message":"Parameter comment must be on the next line","source":"Drupal.Commenting.FunctionComment.ParamCommentNewLine","severity":5,"type":"ERROR","line":178,"column":11},{"message":"Separate the @param and @return sections by a blank line.","source":"Drupal.Commenting.DocComment.TagGroupSpacing","severity":5,"type":"ERROR","line":179,"column":4},{"message":"Return comment must be on the next line","source":"Drupal.Commenting.FunctionComment.MissingReturnComment","severity":5,"type":"ERROR","line":179,"column":4},{"message":"Additional blank lines found at end of doc comment","source":"Drupal.Commenting.DocComment.SpacingAfter","severity":5,"type":"ERROR","line":181,"column":2},{"message":"Opening brace should be on the same line as the declaration","source":"Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine","severity":5,"type":"ERROR","line":183,"column":1},{"message":"Line indented incorrectly; expected 2 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":184,"column":5},{"message":"Variable \"mobileLinkReplace\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":184,"column":5},{"message":"Line indented incorrectly; expected 2 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":185,"column":5},{"message":"Variable \"hpItemSection\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":185,"column":5},{"message":"Line indented incorrectly; expected 2 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":186,"column":5},{"message":"Variable \"mobileApiHPSections\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":186,"column":5},{"message":"Line indented incorrectly; expected 2 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":188,"column":5},{"message":"Variable \"feedId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":188,"column":5},{"message":"Line indented incorrectly; expected 2 spaces, found 4","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":189,"column":5},{"message":"Expected 1 space after IF keyword; 0 found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":189,"column":5},{"message":"Variable \"feedId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":189,"column":14},{"message":"Expected 1 space after closing parenthesis; found \"\\n    \"","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterCloseParenthesis","severity":5,"type":"ERROR","line":189,"column":22},{"message":"Variable \"feedReferenceId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":192,"column":5},{"message":"Variable \"hpItemSection\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":192,"column":24},{"message":"Variable \"feedId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":192,"column":64},{"message":"Expected 1 space after IF keyword; 0 found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":194,"column":5},{"message":"Variable \"feedReferenceId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":194,"column":14},{"message":"Variable \"feedReferenceId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":194,"column":35},{"message":"Expected 1 space after closing parenthesis; found \"\\n    \"","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterCloseParenthesis","severity":5,"type":"ERROR","line":194,"column":57},{"message":"Variable \"feedReferenceId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":196,"column":11},{"message":"Expected 1 space after closing parenthesis; found \"\\n      \"","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterCloseParenthesis","severity":5,"type":"ERROR","line":196,"column":48},{"message":"Variable \"mobileUrl\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":198,"column":9},{"message":"Variable \"mobileLinkReplace\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":198,"column":22},{"message":"Expected 1 space after ELSE keyword; newline found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":200,"column":7},{"message":"Variable \"mobileUrl\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":202,"column":9},{"message":"Variable \"mobileLinkReplace\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":202,"column":22},{"message":"Variable \"feedReferenceId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":202,"column":64},{"message":"Variable \"feedId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":208,"column":130},{"message":"Variable \"mobileUrl\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":209,"column":58},{"message":"Variable \"feedReferenceId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":210,"column":69},{"message":"Variable \"sectionThumbnail\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":212,"column":7},{"message":"Variable \"mobileApiHPSections\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":212,"column":27},{"message":"Variable \"feedReferenceId\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":212,"column":70},{"message":"Expected 1 space after IF keyword; 0 found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":214,"column":7},{"message":"Variable \"sectionThumbnail\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":214,"column":16},{"message":"Expected 1 space after closing parenthesis; found \"\\n      \"","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterCloseParenthesis","severity":5,"type":"ERROR","line":214,"column":34},{"message":"Space found before square bracket; expected \"$form[\" but found \"$form [\"","source":"Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket","severity":5,"type":"ERROR","line":216,"column":15},{"message":"Concat operator must be surrounded by a single space","source":"Squiz.Strings.ConcatenationSpacing.PaddingFound","severity":5,"type":"ERROR","line":217,"column":163},{"message":"Variable \"sectionThumbnail\" is camel caps format. do not use mixed case (camelCase), use lower case and _","source":"Drupal.NamingConventions.ValidVariableName","severity":5,"type":"ERROR","line":217,"column":164},{"message":"Concat operator must be surrounded by a single space","source":"Squiz.Strings.ConcatenationSpacing.PaddingFound","severity":5,"type":"ERROR","line":217,"column":181},{"message":"A comma should follow the last multiline array item. Found: '\" alt=\"Smiley face\" height=\"132\" width=\"228\">'","source":"Drupal.Array.Array.CommaLastItem","severity":5,"type":"WARNING","line":217,"column":182},{"message":"Expected 1 space after ELSE keyword; newline found","source":"Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword","severity":5,"type":"ERROR","line":220,"column":7},{"message":"Line indented incorrectly; expected 8 spaces, found 10","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":222,"column":11},{"message":"Space found before square bracket; expected \"$form[\" but found \"$form [\"","source":"Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket","severity":5,"type":"ERROR","line":222,"column":17},{"message":"A comma should follow the last multiline array item. Found: '<a class=\"fieldset-title\" href=\"#\"><span class=\"fieldset-legend-prefix element-invisible\">Hide<\/span>Content Thumbnail<\/a><br\/><p>No thumbnail available<\/p>'","source":"Drupal.Array.Array.CommaLastItem","severity":5,"type":"WARNING","line":223,"column":24},{"message":"Line indented incorrectly; expected 4 spaces, found 2","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":227,"column":3},{"message":"Closing brace indented incorrectly; expected 4 spaces, found 2","source":"Drupal.WhiteSpace.ScopeClosingBrace.Indent","severity":5,"type":"ERROR","line":227,"column":3},{"message":"Doc comment short description must start with a capital letter","source":"Drupal.Commenting.DocComment.ShortNotCapital","severity":5,"type":"ERROR","line":232,"column":4},{"message":"Doc comment short description must end with a full stop","source":"Drupal.Commenting.DocComment.ShortFullStop","severity":5,"type":"ERROR","line":232,"column":4},{"message":"Parameter comment must be on the next line","source":"Drupal.Commenting.FunctionComment.ParamCommentNewLine","severity":5,"type":"ERROR","line":234,"column":11},{"message":"Parameter comment must be on the next line","source":"Drupal.Commenting.FunctionComment.ParamCommentNewLine","severity":5,"type":"ERROR","line":235,"column":11},{"message":"Separate the @param and @return sections by a blank line.","source":"Drupal.Commenting.DocComment.TagGroupSpacing","severity":5,"type":"ERROR","line":236,"column":4},{"message":"Return comment must be on the next line","source":"Drupal.Commenting.FunctionComment.MissingReturnComment","severity":5,"type":"ERROR","line":236,"column":4},{"message":"Additional blank lines found at end of doc comment","source":"Drupal.Commenting.DocComment.SpacingAfter","severity":5,"type":"ERROR","line":238,"column":2},{"message":"Line indented incorrectly; expected 2 spaces, found 0","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":240,"column":1},{"message":"Line indented incorrectly; expected 2 spaces, found 0","source":"Drupal.WhiteSpace.ScopeIndent.IncorrectExact","severity":5,"type":"ERROR","line":241,"column":1}]}}}
davidbarratt commented 9 years ago

Is there a way for this package to ignore the notices, or do I need to disable display errors?

steelbrain commented 9 years ago

disable display errors sounds like the best solution to me.

davidbarratt commented 9 years ago

@steelbrain,

hmm, I wonder if there is a way to do that an an inline command option?

steelbrain commented 9 years ago

what I would do is edit /Users/dbarratt/sites/somesite/vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Commenting/FunctionCommentSniff.php and fix that 0 index error or append display_errors(0) at the start of that file. It would be a monkeypatch though

davidbarratt commented 9 years ago

Looks like someone already has... https://www.drupal.org/node/2498859

to the dev version!

thanks for your help and making the error reporting more clear. :)

davidbarratt commented 9 years ago

Yep looks like the error was resolved in 8.2.3 which fixed all this. Thanks again for all your help!

steelbrain commented 9 years ago

Pleasure