search

AtomLinter / linter-phpmd

Atom linter plugin for php, using phpmd.
21 stars 4 forks source link

Expand configuration options #115

Closed mdeboer closed 7 years ago

mdeboer commented 7 years ago

As I was getting sick and tired of constantly getting the error message that PHPMD could not be executed in my projects because of a missing phpmd.xml, I decided to make the changes that have already been made to linter-phpcs 😄

Fixes #102. Fixes #106.

mdeboer commented 7 years ago

I suggest this to be released as v1.6.0 as configuration options aren't backwards compatible.

Once this PR is merged I can make another PR for #24 and add the option to configure when to lint, on change or on-the-fly 😄 Maybe, just maybe do the same for linter-phpcs?

Arcanemagus commented 7 years ago

Breaking changes in the configuration would need a major release btw.

mdeboer commented 7 years ago

I'll get on with the changes @Arcanemagus, thank you for your feedback and I'll update this PR tomorrow 👍

mdeboer commented 7 years ago

It took me a little longer, things came up but I think I fixed it all without breaking anything 😉

mdeboer commented 7 years ago

Okay done! 👍

mdeboer commented 7 years ago

There you go, that should be it. Lesson learnt on linters, thanks! Possibly hate writing them more than using them 😜

Arcanemagus commented 7 years ago

Published as v2.0.0, thanks again!

mdeboer commented 7 years ago

Awesome, you're very welcome! Thanks again for your directions 👍 Next on the list is probably being able to lint on-the-fly but we'll see, first have to get back to work 😆

Arcanemagus commented 7 years ago

I'm not sure I'm a fan personally of the way to get linters like this to lint on the fly. The only way that has been figured out so far is to create a temporary file from the current contents, and then lint that. This only works on simple linters that have no dependency on the state of the rest of the project, and causes a lot of I/O.