search

AtomLinter / linter-puppet-lint

Atom linter plugin for Puppet, using puppet-lint
6 stars 3 forks source link

Spec errors have swapped places #156

Open Arcanemagus opened 6 years ago

Arcanemagus commented 6 years ago

We've got a failing build on master from https://github.com/AtomLinter/linter-puppet-lint/pull/155.

It looks like the class not documented error has swapped places with the does_not::exist not in autoload module layout error, which looks to make some sense as it comes before the other.

mschuchard commented 6 years ago

Uncommonly puppet-lint changes the ordering of messages. This also seems to be tied to environments somehow, as the ordering on my workstations syncs with appveyor and travis-ci here, but not travis-ci on another project or circle-ci here. When this happens, I just rerun the CI and then it usually passes.

If anything this is a bug in puppet-lint, but having messages in a specific order is not really going to be high on a priority list.

Also you actually already reported this in #154.

Arcanemagus commented 6 years ago

Uncommonly puppet-lint changes the ordering of messages.

Oh, lovely. Good to know!

If anything this is a bug in puppet-lint, but having messages in a specific order is not really going to be high on a priority list.

If puppet-lint doesn't provide a way to request ordered results there is nothing we can do about that here. We might rewrite the tests to simply look for messages with those contents, instead of the exact order they are coming in as.

Also you actually already reported this in #154.

Ha! Apparently it is the same issue. Closing that in favor of this as it is far more descriptive. Thanks!

mschuchard commented 6 years ago

As an example of somewhere else this occurs, my puppet-lint parsing test at puppet-check always has that order specified in the regular expression on the travis-ci matrix, but always has the reverse order on my laptop.