AtomLinter / linter-reek

An Atom Linter package for Reek, the Ruby code smell detector.
https://atom.io/packages/linter-reek
MIT License
7 stars 5 forks source link

Parse reek output line by line #13

Closed povilasjurcys closed 8 years ago

povilasjurcys commented 8 years ago

This fix should solve #11 issue. Before we put put all reek output in one object that was passed to linter. Now we split reek output by lines ar parse every line separately

steelbrain commented 8 years ago

Is creating a separate class for output parser really necessary? We also have a parse method in the helper module that parses it line-by-line via a provided regex.

povilasjurcys commented 8 years ago

It looked more OOP until you told me about atom-linter parse method

steelbrain commented 8 years ago

Thanks! Now all we need is someone testing this and confirming that it works.

dathagerty commented 8 years ago

Merged in.