search

AtomLinter / linter-reek

An Atom Linter package for Reek, the Ruby code smell detector.
https://atom.io/packages/linter-reek
MIT License
7 stars 5 forks source link

Implement specs #26

Closed Arcanemagus closed 8 years ago

Arcanemagus commented 8 years ago

It looks like this linter does not currently have any specs written for it, adding it to the list being maintained here for tracking.

Specs do not need to be super detailed, as they should mainly test whether the package is properly running the linter plugin and parsing its messages. Leave testing of the linter functionality to the author of the linter.

If you need any help feel free to ask!

dathagerty commented 8 years ago

I'll get on this. I've got a big milestone due for a project at work this week, and once that's done I'll get to work writing out some simple specs.

Arcanemagus commented 8 years ago

If you want help I can throw some basic specs together.

dathagerty commented 8 years ago

@Arcanemagus If you wouldn't mind getting a branch set up with some basic specs, I should be able to work on it tomorrow and get this closed.

Arcanemagus commented 8 years ago

Okay

dathagerty commented 8 years ago

I like it. Honestly, for now I think this might be enough for our specs. It verifies that the linter is loaded and responds properly to dirty and clean files. Anything more I can think of implementing will just be testing Reek itself.

Arcanemagus commented 8 years ago

Really the only thing that could be tested further is the executable path and any other settings that can be configured.