search

AtomLinter / linter-reek

An Atom Linter package for Reek, the Ruby code smell detector.
https://atom.io/packages/linter-reek
MIT License
7 stars 5 forks source link

Update package.json #45

Closed dathagerty closed 8 years ago

dathagerty commented 8 years ago

Changed to use a more forgiving dependency declaration. Now, Greenkeeper.io won't need to alert me whenever one of the dependencies has a patch version update.

steelbrain commented 8 years ago

An alternative way to avoid that PR by greenkeeper would be to add specs to your package

dathagerty commented 8 years ago

I have specs, the issue is that the way I declared dependencies specified versions all the way down to patch level. So in the past few days, I've seen about 6 or 7 emails to update the patch number of just two dependencies.

Arcanemagus commented 8 years ago

Actually this PR made the versions less forgiving. Caret ranges mean "compatible with", and in essence translate something like ^4.5.0 into >=4.5.0 <5.0.0. On the other hand 4.5.x translates into >=4.5.0 <4.6.0.

The reason you had so many PR's on those two dependencies is that your current version range didn't allow for those versions because they were major updates. (See here, here, here, and here)

Or, they were just minor/patch updates to major updates that hadn't been merged in yet.

Previously you would have been notified for every major release, and anything breaking. With this change you will be notified for every minor release and anything breaking.