Update eslint to version 3.4.0 🚀

greenkeeperio-bot commented 8 years ago

Hello lovely humans,

eslint just published its new version 3.4.0.

State	Update :rocket:
Dependency	eslint
New version	3.4.0
Type	devDependency

This version is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of eslint. Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right? Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project :sparkles:

You rock!

:palm_tree:

GitHub Release

c210510 Update: add fixer for no-extra-parens (fixes #6944) (#6950) (not-an-aardvark)
ca3d448 Fix: prefer-const false negative about eslintUsed (fixes #5837) (#6971) (Toru Nagashima)
1153955 Docs: Draft of JSCS migration guide (refs #5859) (#6942) (Nicholas C. Zakas)
3e522be Fix: false negative of indent with else if statements (fixes #6956) (#6965) (not-an-aardvark)
2dfb290 Docs: Distinguish examples in rules under Stylistic Issues part 7 (#6760) (Kenneth Williams)
3c710c9 Fix: rename "AirBnB" => "Airbnb" init choice (fixes #6969) (Harrison Shoff)
7660b39 Fix: object-curly-spacing for type annotations (fixes #6940) (#6945) (Toru Nagashima)
21ab784 New: do not remove non visited files from cache. (fixes #6780) (#6921) (Roy Riojas)
3a1763c Fix: enable @scope/plugin/ruleId-style specifier (refs #6362) (#6939) (Toru Nagashima)
d6fd064 Update: Add never option to multiline-ternary (fixes #6751) (#6905) (Kai Cataldo)
0d268f1 New: symbol-description rule (fixes #6778) (#6825) (Jarek Rencz)
a063d4e Fix: no-cond-assign within a function expression (fixes #6908) (#6909) (Patrick McElhaney)
16db93a Build: Tag docs, publish release notes (fixes #6892) (#6934) (Nicholas C. Zakas)
0cf1d55 Chore: Fix object-shorthand errors (fixes #6958) (#6959) (Kai Cataldo)
8851ddd Fix: Improve pref of globbing by inheriting glob.GlobSync (fixes #6710) (#6783) (Kael Zhang)
cf2242c Update: requireStringLiterals option for valid-typeof (fixes #6698) (#6923) (not-an-aardvark)
8561389 Fix: no-trailing-spaces wrong fixing (fixes #6933) (#6937) (Toru Nagashima)
6a92be5 Docs: Update semantic versioning policy (#6935) (alberto)
a5189a6 New: class-methods-use-this rule (fixes #5139) (#6881) (Gyandeep Singh)
1563808 Update: add support for ecmaVersion 20xx (fixes #6750) (#6907) (Kai Cataldo)
d8b770c Docs: Change rule descriptions for consistent casing (#6915) (Brandon Mills)
c676322 Chore: Use object-shorthand batch 3 (refs #6407) (#6914) (Kai Cataldo)

The new version differs by 368 commits .

faab36e 3.4.0
609ed97 Build: package.json and changelog update for 3.4.0
c210510 Update: add fixer for no-extra-parens (fixes #6944) (#6950)
ca3d448 Fix: prefer-const false negative about eslintUsed (fixes #5837) (#6971)
1153955 Docs: Draft of JSCS migration guide (refs #5859) (#6942)
3e522be Fix: false negative of indent with else if statements (fixes #6956) (#6965)
2dfb290 Docs: Distinguish examples in rules under Stylistic Issues part 7 (#6760)
3c710c9 Fix: rename "AirBnB" => "Airbnb" init choice (fixes #6969)
7660b39 Fix: object-curly-spacing for type annotations (fixes #6940) (#6945)
21ab784 New: do not remove non visited files from cache. (fixes #6780) (#6921)
3a1763c Fix: enable @scope/plugin/ruleId-style specifier (refs #6362) (#6939)
d6fd064 Update: Add never option to multiline-ternary (fixes #6751) (#6905)
0d268f1 New: symbol-description rule (fixes #6778) (#6825)
a063d4e Fix: no-cond-assign within a function expression (fixes #6908) (#6909)
16db93a Build: Tag docs, publish release notes (fixes #6892) (#6934)

There are 250 commits in total. See the full diff.

This pull request was created by greenkeeper.io.

_{Tired of seeing this sponsor message? :zap: greenkeeper upgrade}

Arcanemagus commented 8 years ago

Things to handle when updating:

[x] Node.js >= v4 for installation and running of eslint (#83)
[x] Fix any lint issues exposed by the new eslint
[x] eslint-plugin-import@^1.10.2 for eslint@3 compatibility (359e348572b7d0a65af946b0f0f80468ef91edc0)
[x] eslint-config-airbnb-base@^4.0.0 for eslint@3 compatibility (#77)

dathagerty commented 8 years ago

@Arcanemagus, what would be the best way to ensure the proper Node is being used?

dathagerty commented 8 years ago

@Arcanemagus Never mind, I think I got it.

Arcanemagus commented 8 years ago

Actually the problem is mainly in the CI scripts, I'll send in a PR updating them.

Arcanemagus commented 8 years ago

Blocked on #83.

Arcanemagus commented 8 years ago

Of course when Atom v1.10.0 releases the CI updates will be irrelevant as the apm bundled with that version updates to Node.js v4.4.5 😁.

Arcanemagus commented 8 years ago

Rebased on master, updated the remaining dependencies. No lint issues so it's just a matter of waiting on CI 😁.

Arcanemagus commented 8 years ago

The CI build status is all green, merging!

Arcanemagus commented 8 years ago

Huh, GitHub changed the squash and merge commit format.

AtomLinter / linter-reek

Update eslint to version 3.4.0 🚀 #80