AtomLinter / linter-reek

An Atom Linter package for Reek, the Ruby code smell detector.
https://atom.io/packages/linter-reek
MIT License
7 stars 5 forks source link

Re-write in ES2015 #89

Closed Arcanemagus closed 7 years ago

Arcanemagus commented 7 years ago

Re-write the linter in ES2015, with the following big changes:

Also includes several smaller changes:

Fixes #88.

Arcanemagus commented 7 years ago

@dhagerty9009 I split this up a bit so it was obvious what was fixing the existing specs, and what was part of the actual re-write. If you want this focused on just the re-write I can move those off into a separate branch.

Arcanemagus commented 7 years ago

Almost forgot, the new regex can be seen in action here: https://regex101.com/r/99zZs8/1

Arcanemagus commented 7 years ago

@dhagerty9009 I'll be merging this tomorrow morning unless you have something you see needs changing before then 😉.

Arcanemagus commented 7 years ago

Well, tomorrow morning has turned into 4 days later :stuck_out_tongue:, merging this as CI is passing and no feedback has been received for any changes.