Closed Arcanemagus closed 7 years ago
@dhagerty9009 I split this up a bit so it was obvious what was fixing the existing specs, and what was part of the actual re-write. If you want this focused on just the re-write I can move those off into a separate branch.
Almost forgot, the new regex can be seen in action here: https://regex101.com/r/99zZs8/1
@dhagerty9009 I'll be merging this tomorrow morning unless you have something you see needs changing before then 😉.
Well, tomorrow morning has turned into 4 days later :stuck_out_tongue:, merging this as CI is passing and no feedback has been received for any changes.
Re-write the linter in ES2015, with the following big changes:
lintOnFly
tofalse
. This linter is currently only linting the file on disk, not the current contents so this should befalse
.helpers.rangeFromLineNumber
to generate a range. Sincereek
only provides a line, it will generate a range highlighting the entire line.Also includes several smaller changes:
configSchema
property inpackage.json
.helpers.parse
for the most part, just stop using that function entirely.Fixes #88.