search

AtomLinter / linter-scss-lint

Linter plugin for SCSS, using scss-lint
36 stars 21 forks source link

Update atom-linter to version 9.0.0 🚀 #201

Closed greenkeeper[bot] closed 7 years ago

greenkeeper[bot] commented 7 years ago

Version 9.0.0 of atom-linter just got published.

Dependency atom-linter
Current Version 8.0.0
Type dependency

The version 9.0.0 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of atom-linter. Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

Commits

The new version differs by 15 commits .

  • aa99eff Prepare v9.0.0 release
  • 1c13ce0 Cleanup the changelog
  • d2bdb3b Merge pull request #153 from steelbrain/arcanemagus/rename-rfln
  • e63ec0c Rename rangeFromLineNumber to generateRange
  • 55757f9 Merge pull request #152 from steelbrain/arcanemagus/xplat-clean
  • 91fb6ce Use rimraf for cross-platform clean script
  • 1c68697 Merge pull request #151 from steelbrain/arcanemagus/array-range
  • 5e2fa88 Return Range-compatible Array from rangeFromLineNumber
  • 1a252f2 :arrow_up: Bump sb-exec to 3.1.0
  • 5a92588 :new: Show line number in col too big error messages
  • 8bdfa68 :arrow_up: Bump sb-exec to v3.0.3
  • 693196b Merge pull request #149 from steelbrain/steelbrain/handle-enoent-properly
  • 0b70af5 ✅ Add specs for change
  • d75ff07 :memo: Document changes in CHANGELOG
  • b30db86 :new: Handle ENOENT properly

See the full diff.

Not sure how things should work exactly? There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

This change is Reviewable

Arcanemagus commented 7 years ago

Looks like the specs need updating to cover the case where rangeFromLineNumber was used.

Arcanemagus commented 7 years ago

Apparently the JSON reporter always returns a .length for messages, meaing that that bit of code will never be hit.

Since there must be a reason it was in there in the first place, possibly older versions can still hit that, so I'll just update the function name so it will work, but current versions can't hit it.