AtomLinter / linter-spell-latex

Provider for Atom linter-spell package to enable LaTeX spell checking.
MIT License
8 stars 7 forks source link

No spell checking at all #25

Open mlangiu opened 7 years ago

mlangiu commented 7 years ago

Description

I am not able to get linter-spell-latex to do anything when trying it on this basic test file:

%!TeX spellcheck = en-US,en-DE
\documentclass{standalone}
\begin{document}
  It wourld be so naice if tihs woudl be correctted!
\end{document}

Steps to Reproduce

Versions and installed packages

Mac OS 10.12.5

Atom : 1.19.2 Electron: 1.6.9 Chrome : 56.0.2924.87 Node : 7.4.0

atom-latex@0.8.1 busy-signal@1.4.3 intentions@1.1.5 language-gams@0.4.0 language-gnuplot-atom@0.2.0 language-latex@1.1.1 linter@2.2.0 linter-spell@0.15.0 linter-spell-latex@0.10.0 linter-ui-default@1.6.7

maa-x commented 7 years ago

I have the same issue. I would like to additionally confirm that creating a .txt file with mistakes works, this is definitely something to do with this package and not linter-spell

Aerijo commented 6 years ago

@mlangiu @MaxIsMyName Does the package appear in the list returned by the following command?

atom.packages.activePackages

Open dev tools and type the above into the console. It should return a list of all active packages.

mlangiu commented 6 years ago

Hey Aerijo, thanks for getting back on this! No, I only see

not linter-spell-latex!

screen shot 2017-12-17 at 12 43 20

Aerijo commented 6 years ago

It looks like the activation hook isn't working for some reason. Did you do that after opening and viewing a .tex file (I see one in the next tab). The hook should activate when it detects that the language-latex package's grammar has been used.

mlangiu commented 6 years ago

I opened atom, then the tex file, then the dev console

Aerijo commented 6 years ago

If that still doesn't work, go to the settings for linter-spell-latex and click the View Code button. A window should popup; in the package.json file (in the package root directory), search for activationHooks. Delete this entry and it's contents. Finally, reload Atom and try the above again. It should definitely have activated this time.

mlangiu commented 6 years ago

Perfect that seems to do the trick!

Unfortunately the correction process isn't working properly:

But since that seems like a more general issue (happens for normal text files as well) I'll report it on linter-spell as well. Thanks for the help

Aerijo commented 6 years ago

Yeah, I don't know much about the internals of how that works. I'm also still not sure why your activation hooks weren't working, but I'm glad you could work around it.

This issue should probably be left open, at least until a maintainer can read the conversation and determine if it's worth following up on. Like I said; I don't know if the issue is with this package or Atom's handling of activationHooks in general.

schneiderfelipe commented 4 years ago

If that still doesn't work, go to the settings for linter-spell-latex and click the View Code button. A window should popup; in the package.json file (in the package root directory), search for activationHooks. Delete this entry and it's contents. Finally, reload Atom and try the above again. It should definitely have activated this time.

I managed to see linter-spell-latex activated after doing this. I'm using Atom 1.28.2 under Ubuntu 18.04.4 LTS. I did all the steps mentioned by @mlangiu in this issue.

On the other hand, I see things such as documentclass being "corrected".

anupanandsingh commented 4 years ago

Yeah, I don't know much about the internals of how that works. I'm also still not sure why your activation hooks weren't working, but I'm glad you could work around it.

This issue should probably be left open, at least until a maintainer can read the conversation and determine if it's worth following up on. Like I said; I don't know if the issue is with this package or Atom's handling of activationHooks in general.

@Aerijo, do we know a way to make it work now? I have tried the hacks listed on this page as well as here. Nothing seems to work. Thank you!