AtomMaterialUI / a-file-icon-idea

Atom Material Icons for JetBrains - Replace File and UI Icons for better visual grepping.
http://www.material-theme.com/docs/configuration/icons-settings/#atom-material-icons-plugin
MIT License
220 stars 27 forks source link

Support folder/ file path matching if the pattern contains forward slash #333

Closed yogeshlonkar closed 1 year ago

yogeshlonkar commented 1 year ago

Description

Added path field to VirtualFileInfo. It is used while matching file/ folder association pattern, if the pattern contains forward slash /.

Motivation and Context

Allows to set folder icons relative to parent folder in languages where parent folder provides special meaning such as golang, rust etc. See the screenshots below

Screenshots (if appropriate):

Icons for subfolders relative_folder_association

Setting used to set icons relative to parent folder relative_folder_association_settings

Types of changes

Checklist:

welcome[bot] commented 1 year ago

Thanks for opening this pull request! Please check out our contributing guidelines.

ghost commented 1 year ago
👇 Click on the image for a new way to code review - Make big changes easier — review code in small groups of related files - Know where to start — see the whole change at a glance - Take a code tour — explore the change with an interactive tour - Make comments and review — all fully sync’ed with github [Try it now!](https://app.codesee.io/r/reviews?pr=333&src=https%3A%2F%2Fgithub.com%2Fmallowigi%2Fa-file-icon-idea)

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

mallowigi commented 1 year ago

😮😲

Good job!!! I will merge it as soon as I'm done with the other stuff on my backlog.

Impressive

welcome[bot] commented 1 year ago

Congrats on merging your first pull request! We here at behaviorbot are proud of you!

yogeshlonkar commented 1 year ago

@mallowigi Thanks 🙏🏼 Really awesome plugin