AtomMaterialUI / a-file-icon-idea

Atom Material Icons for JetBrains - Replace File and UI Icons for better visual grepping.
http://www.material-theme.com/docs/configuration/icons-settings/#atom-material-icons-plugin
MIT License
220 stars 27 forks source link

New UI - StackOverflowError #338

Closed jb00ster closed 1 year ago

jb00ster commented 1 year ago

Describe the bug Intellij with new UI, keeps showing error popup related to this plugin

To Reproduce

  1. after plugin installation and IDEA restart, error appears after a moment without doing nothing

Environment IntelliJ IDEA 2022.3 (Ultimate Edition) Build #IU-223.7571.182, built on November 29, 2022 Runtime version: 17.0.5+1-b653.14 amd64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o. Linux 5.15.0-56-generic GC: G1 Young Generation, G1 Old Generation Memory: 996M Cores: 8 Registry: debugger.new.tool.window.layout=true ide.experimental.ui=true

Non-Bundled Plugins: com.jetbrains.plugins.ini4idea (223.7571.233) org.intellij.plugins.hcl (223.7571.175) ru.adelf.idea.dotenv (2022.3) com.mallowigi (81.0.0) aws.toolkit (1.57-223)

Kotlin: 223-1.7.20-release-201-IJ7571.182 Current Desktop: ubuntu:GNOME

Atom Material File Icons version 81.0.0

Screenshots

EnableFileIconsAction#update@MainToolbar (com.mallowigi.actions.EnableFileIconsAction), actionId=EnableFileIconsAction, text='File Icons'

java.lang.StackOverflowError
    at com.intellij.ui.LayeredIcon.updateSize(LayeredIcon.java:295)
        at com.intellij.util.SmartList.forEach(SmartList.java:347)
    at com.intellij.ui.scale.UserScaleContext.notifyUpdateListeners(UserScaleContext.java:274)
    at com.intellij.ui.scale.UserScaleContext.onUpdated(UserScaleContext.java:194)
    at com.intellij.ui.scale.UserScaleContext.setScale(UserScaleContext.java:147)
    at com.intellij.ui.scale.UserScaleContext.update(UserScaleContext.java:205)
    at com.intellij.ui.LayeredIcon.getIconWidth(LayeredIcon.java:260)
    at com.mallowigi.actions.IconToggleAction$selectedFallbackIcon$1.getIconWidth(IconToggleAction.kt:96)
    at com.intellij.ui.LayeredIcon.updateSize(LayeredIcon.java:295)
    at com.intellij.util.SmartList.forEach(SmartList.java:347)
    at com.intellij.ui.scale.UserScaleContext.notifyUpdateListeners(UserScaleContext.java:274)
    at com.intellij.ui.scale.UserScaleContext.onUpdated(UserScaleContext.java:194)
    at com.intellij.ui.scale.UserScaleContext.setScale(UserScaleContext.java:147)
welcome[bot] commented 1 year ago

Thanks for opening your first issue here! Be sure to follow the issue template!

mallowigi commented 1 year ago

Can you provide your settings?

mallowigi commented 1 year ago

I can't reproduce, but I found the code part that might cause the issue. Please try to install this file and tell me if it fixes the issue, thanks

Atom Material Icons-81.0.1.zip

Rainsheep commented 1 year ago

I also encountered this problem and used a new version. It has not been reproduced for the time being. If it occurs again, I will contact you again

intellitour commented 1 year ago

I'm giving it a try today.

intellitour commented 1 year ago

@mallowigi I've been using the modified zip you provided for a while... no issues til now. I believe it is a fix!