AtomMaterialUI / a-file-icon-idea

Atom Material Icons for JetBrains - Replace File and UI Icons for better visual grepping.
http://www.material-theme.com/docs/configuration/icons-settings/#atom-material-icons-plugin
MIT License
218 stars 27 forks source link

"Enable PSI Icons" results in broken icons in Randomness plugin #434

Closed FWDekker closed 1 month ago

FWDekker commented 5 months ago

Describe the bug Using both Atom Material Icons and Randomness (of which I am the developer) in IntelliJ's New UI results in broken icons in the Randomness plugin. In the "Broken icons" screenshot below, observe the missing horizontal and vertical line in each icon.

Correct icons Broken icons
Normal icons, with mostly filled-in squares. Broken icons, with a horizontal and a vertical line missing in each icon.

Before reporting this issue, I tried to make sure this is not a bug in Randomness. The only code relevant for icons is the Icons file, but even after removing most of the code there (including the RadialColorReplacementFilter), and stripping my code down so that it essentially just directly displays an icon, the issue persists. Therefore, I am convinced this is an issue with the Atom Material Icons plugin.

To Reproduce

  1. Use IntelliJ 2023.3 or newer.
  2. Use Atom Material Icons v94.0.0 or newer.
  3. Use Randomness v3.0.0 or newer.
  4. Enable the New UI.
  5. Press Alt + R (or ⌥R) while no modal dialogs are open.

Disabling "Enable PSI Icons" in the Atom Material Icons settings and then restarting removes the issue. Re-enabling that setting and then restarting brings back the broken icons.

Expected Behavior See images above.

Environment

IntelliJ IDEA 2023.3 (Community Edition)
Build #IC-233.11799.241, built on December 2, 2023
Runtime version: 17.0.9+7-b1087.7 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Linux 6.5.0-5-amd64
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 16
Registry:
  ide.experimental.ui=true
Non-Bundled Plugins:
  com.fwdekker.randomness (3.2.0)
  com.mallowigi (94.1.0)
Kotlin: 233.11799.241-IJ
Current Desktop: KDE

Screenshots See images above.

mallowigi commented 5 months ago

Fixed it but only for 2024.1 only for now. I'll issue another fix at some point

FWDekker commented 5 months ago

Awesome, thank you! :-)