Scala constructor and method parsing

AtomMaterialUI / color-highlighter

JetBrains plugin to preview colors directly from within the code.

MIT License

46 stars 26 forks source link

Scala constructor and method parsing #128

Closed OndrejSpanel closed 1 year ago

OndrejSpanel commented 1 year ago

Description

Similar to Scala and Kotlin, this adds constructor and method parsing to Scala.

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-Functional Change (non-user facing changes)

Checklist:

[x] My code follows the code style of this project (./gradlew check passes clean).
- Tip: If you have lint issues just run ./gradlew :ktlintMainSourceSetFormat.
[x] I updated the version.
[x] I updated the changelog with the new functionality.

_{Mention [stepsize] in a comment if you'd like to report some technical debt. See examples here.}

OndrejSpanel commented 1 year ago

@mallowigi I can add a Scala configuration like there already is for Java and Kotlin, but does it make sense, as it will be more or less another copy? Perhaps it would be better to merge the configuration for all those three languages into one?

mallowigi commented 1 year ago

If they are a carbon copy of the others, you can reuse the others

OndrejSpanel commented 1 year ago

What I mean is - do you want to have separate settings for Java / Kotlin / Scala, or should they be merged together? At the moment Kotlin and Java have separate settings, controlling the same functionality differently for different languages.

I think I can add another one for Scala or all three should be merged together. It would feel strange for Scala to share settings with Java when Kotlin has their own.

mallowigi commented 1 year ago

Yeah I can see from your PR. Ultimately we should use a different setting for this, but this would involve you to also touch the Configurable and State files.

OndrejSpanel commented 1 year ago

If you prefer that, I will do it that way.

OndrejSpanel commented 1 year ago

Separate Scala settings added

mallowigi commented 1 year ago

Thanks for your hard work. I will try to find some time in the weekend to check that nothing is broken with all these refactors

stale[bot] commented 1 year ago

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.