AtomMaterialUI / color-highlighter

JetBrains plugin to preview colors directly from within the code.
MIT License
44 stars 25 forks source link

Highlighting style does nothing #165

Open tatof opened 2 months ago

tatof commented 2 months ago

Describe the bug Highlighting style doesnt work. I tried all settings and restarted the IDEA many times. What am i doing wrong? It only displays as "background" color.

To Reproduce

  1. install plugin
  2. try different highlighting options

Expected Behavior See difference :)

Environment PhpStorm 2024.1.1 Build #PS-241.15989.102, built on April 23, 2024 Licensed to J B Subscription is active until March 2, 2025. Runtime version: 17.0.10+1-b1207.14 amd64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o. Windows 10.0 GC: G1 Young Generation, G1 Old Generation Memory: 4096M Cores: 24 Registry: run.processes.with.pty=TRUE ide.experimental.ui=true Non-Bundled Plugins: com.jetbrains.space (241.15989.9) color.scheme.Tomorrow Dark (0.2) com.intellij.ideolog (222.3.2.0) com.vecheslav.darculaDarkerTheme (1.2.0) com.github.lppedd.kotlin-additional-highlighting (0.2.2) com.intellij.ml.llm (241.15989.195) ru.adelf.idea.dotenv (2024.1) com.mallowigi.colorHighlighter (18.0.0)

It should contain: Windows

Screenshots image

mallowigi commented 2 months ago

I think you're right, it doesn't work for CSS because this is handled by the IDE, not the plugin. And the IDE only knows to style the background.

CleanShot 2024-08-13 at 16 51 09

tatof commented 2 months ago

Thought the same, is there a workaround? Really want to change de default behavior. (got a lot of colors) would love to change the default to a underline or something like that.

mallowigi commented 2 months ago

I need to create a CSSParser. I did it for all other formats but for CSS I was resorting to the IDE options because otherwise they would conflict each other (like, if you enable Foreground coloring in the plugin but background coloring in the Appearance setting, you would be getting a colored box).

I need to think of a solution.

tatof commented 2 months ago

I understand the problem, I hoped it wouldn't relay on the IDE setting. Tried to turn of IDE background color setting but saw it also changed in the plugin.

Maybe automatic turn off the IDE setting if the plugin CSS setting is on?

mallowigi commented 2 months ago

Hmm that might be possible

mallowigi commented 1 month ago

CSS support will be added next version

tatof commented 1 month ago

Nice! makes me really happy 😁

tatof commented 1 month ago

The latest update 18.1.0 doesn't work as described above. Is this feature included in this update?

mallowigi commented 1 month ago

Should be, what IDE are you on?

tatof commented 1 month ago

PhpStorm 2024.2.1 Build #PS-242.21829.154, built on August 29, 2024

Runtime version: 21.0.3+13-b509.11 amd64 (JCEF 122.1.9) VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o. Toolkit: sun.awt.windows.WToolkit Windows 10.0 GC: G1 Young Generation, G1 Concurrent GC, G1 Old Generation Memory: 4096M Cores: 24 Registry: run.processes.with.pty=TRUE ide.experimental.ui=true i18n.locale= Non-Bundled Plugins: com.jetbrains.space (242.21829.142) color.scheme.Tomorrow Dark (0.2) com.intellij.ideolog (242.21829.162) com.vecheslav.darculaDarkerTheme (1.2.0) com.github.lppedd.kotlin-additional-highlighting (0.2.2) com.intellij.ml.llm (242.21829.196) org.jetbrains.plugins.gitlab (242.21829.162) org.jetbrains.plugins.github (242.21829.162) ru.adelf.idea.dotenv (2024.2.1) com.mallowigi.colorHighlighter (18.1.0)

mallowigi commented 1 month ago

Did you turn on the setting ?

tatof commented 1 month ago

What setting? Highlight CSS colors is ON But that also automatically turns on "general -> appearance" -> Show css color preview as background. Can't turn that off and keep your plugin on

image

mallowigi commented 1 month ago

aaah good catch!

tatof commented 1 week ago

Any updates on this request? 😁 I really want to use this plugin

mallowigi commented 1 week ago

Sorry I have other priorities at the moment

tatof commented 5 days ago

can happen! no problem :)