Closed VapidLinus closed 3 years ago
Just want to add that I appreciate the recently added C# support in the first place heart ❤️
Yes I know, this is because C# does not tokenize expressions like in Java, instead they tokenize every item, e.g Color
, FromArgb
, etc. So there is no way to simply colorize the expression after the =
That's also why I added a setting to disable it if it is too much.
@mallowigi
Could you consider an option that disables the highlighting of the entire line but still keep the gutter icon (the colour to the left near the line numbers)?
Rider does some colour highlighting on its own under the FromArgb
so I find disabling the option you mentioned perfectly okay. I would love an option that disables the highlighting of the line but keeps the gutter square colour icon.
Would that be reasonable? :)
It's a bit harder to do but I'll add it to the backlog
-- Elior On 1 Oct 2021, 8:33 +0200, Linus Närkling @.***>, wrote:
@mallowigi Could you consider an option that disables the highlighting of the entire line but still keep the gutter icon (the colour to the left near the line numbers)? Rider does some colour highlighting on its own under the FromArgb so I find disabling the option you mentioned perfectly okay. I would love an option that disables the highlighting of the line but keeps the gutter square colour icon. Would that be reasonable? :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.
Describe the bug When defining colours using
Color.FromArgb(int,int,int)
the entire line gets highlighted in the colour. When usingColorTranslator.FromHtml(string)
only the definition gets highlighted in the colour.Here's a preview of what I mean: https://i.imgur.com/esaRQfF.png https://i.imgur.com/U43G9u2.png
The entire line turning into the colour is unwanted.
ColorTranslator.FromHtml(string)
is the wanted apperance.To Reproduce Define two properties. One using
ColorTranslator.FromHtml(string)
and one usingColor.FromArgb(int,int,int)
. You will notice the two lines appear differently.Expected Behavior For only the paramaters part inside the parantehesses in
Color.FromArgb(int, int, int)
to get highligthed in the colour.Environment
Screenshots https://i.imgur.com/esaRQfF.png https://i.imgur.com/U43G9u2.png