AtomMaterialUI / material-theme-issues

Issues Repository for the Material Theme UI plugin for JetBrains
Other
64 stars 4 forks source link

[Bug]: Custom color for directories with changed descendants is not working #412

Closed simonschaufi closed 1 year ago

simonschaufi commented 1 year ago

Describe the bug

Having set a custom color for directories with changed descendants is not working

To Reproduce

  1. Go to Appearance & Behavior -> Material Theme UI -> Settings -> Tab Project View
  2. Activate Custom directories Style
  3. Click "Click here to configure Directories Colors"
  4. Change "Have changed descendants" and "Have immediate changed children" Foreground color
  5. Click OK
  6. Change any file
  7. File color is changed but NOT the parent directories

Expected behavior

All the parent directories get a different color

Material Theme Version

8.12.2

IDE

PHPStorm

System Info

No response

Logs/Screenshots

No response

mallowigi commented 1 year ago

These are IDEA's status file colors. If they don't work with the plugin off, they won't work with the plugin on either.

simonschaufi commented 1 year ago

Why do you close this issue? When I disable the plugin, it works without problems. When I enable the plugin again, it doesn't work again so it must be an issue with this plugin.

mallowigi commented 1 year ago

Can you provide your settings ? And share some screenshots?

simonschaufi commented 1 year ago

settings-2023-10-07.zip

image

with custom directory colors disabled:

image

with custom directory colors activated:

image

image

same color as "Have immediate changed children".

As you can see, the directories are all white but the parents of the changed file should have the color #0DF1DE

mallowigi commented 1 year ago

Hi, I tried to reproduce but without avail. That being said according to your screenshots, you're mentioning that the issue happens when "custom directory style" is enabled, isn't that right?

In that case, it makes sense, because that color is controlled by the "Directories" key of that same screen.

simonschaufi commented 1 year ago

Hi, I tried to reproduce but without avail.

What does that mean? Do you see the directory in a different color when you change something?

when "custom directory style" is enabled, isn't that right?

yes that is right.

In that case, it makes sense, because that color is controlled by the "Directories" key of that same screen.

I don't understand this at all.

mallowigi commented 1 year ago

https://material-theme.com/docs/configuration/file-status-colors/#directories

File Status Colors - Material Theme UI Documentation
Customize File Status Colors
simonschaufi commented 1 year ago

Dear @mallowigi, instead of just closing this issue, could you take my issue serious please? Whenever I switch on the "Custom Directory Style", they have no effect. It is not working for me! Is it working for you?

mallowigi commented 1 year ago

I sent you a link explaining what I meant with my previous message. Please read what's in that link.