AtomMaterialUI / material-theme-issues

Issues Repository for the Material Theme UI plugin for JetBrains
Other
62 stars 4 forks source link

[SOLVED]: Large gutter after 2024.1 upgrade #476

Closed luispabon closed 3 months ago

luispabon commented 3 months ago

Describe the bug

Material UI disabled: image

Material UI enabled: image

Observations:

To Reproduce

  1. Install pycharm 2024.1
  2. Install material UI
  3. Profit

Expected behavior

Line numbers panel is the correct size.

Material Theme Version

v9.1.0

IDE

PyCharm

System Info

Ubuntu 23.10

PyCharm 2024.1 (Professional Edition)
Build #PY-241.14494.241, built on March 28, 2024
Licensed to  [ ... ]
Runtime version: 17.0.10+8-b1207.12 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Linux 6.2.0-37-generic
GC: G1 Young Generation, G1 Old Generation
Memory: 3974M
Cores: 8
Registry:
  ide.balloon.shadow.size=0
  editor.distraction.free.mode=true
  debugger.new.tool.window.layout=true
  ide.new.editor.tabs.vertical.borders=true
  ide.linux.hide.native.title=false
  ide.experimental.ui=true
  ide.editor.tab.selection.animation=true
Non-Bundled Plugins:
  io.github.fstaudt.helm (0.8.2)
  net.sjrx.intellij.plugins.systemdunitfiles (223.240127.136)
  com.mnr.java.intellij.idea.plugin.base64helper (3.0.0)
  ru.sadv1r.ansible-vault-editor-idea-plugin (1.21)
  org.intellij.plugins.hcl (241.14494.150)
  de.netnexus.camelcaseplugin (3.0.12)
  lermitage.intellij.ilovedevtoys (1.10.2)
  org.jetbrains.plugins.go-template (241.14494.150)
  codes.rudolph.idea.cfg (0.3.1)
  com.intellij.ideolog (222.3.2.0)
  name.kropp.intellij.makefile (241.14494.150)
  ir.msdehghan.plugins.ansible (0.92)
  dev.meanmail.plugin.nginx-intellij-plugin (2022.1.1)
  indent-rainbow.indent-rainbow (2.2.0)
  com.intellij.kubernetes (241.14494.150)
  net.seesharpsoft.intellij.plugins.csv (3.3.0-241)
  com.intellij.ml.llm (241.14494.240)
  izhangzhihao.rainbow.brackets (2024.2.2-241)
  net.ashald.envfile (3.4.2)
  ru.adelf.idea.dotenv (2024.1)
  com.chrisrm.idea.MaterialThemeUI (9.1.0)
  com.fapiko.jetbrains.plugins.better_direnv (1.2.2)
  com.mallowigi (95.0.0)
  mobi.hsz.idea.gitignore (4.5.2)
  com.github.blarc.gitlab-template-lint-plugin (1.13.2)
Current Desktop: sway

Logs/Screenshots

No response

mallowigi commented 3 months ago

Settings > Centered Editor

luispabon commented 3 months ago

That did the trick 👍🏽 I don't recall enabling that setting at any point though, perhaps a bad default for this version of intellij?

mallowigi commented 3 months ago

No. It's a new feature of the Material Theme UI. It's enabled by default for all users.

I need to write an article about this but bottomline, this centers the editor rather than pin it to the left. This is especially great when the tool windows are collapsed, mimicking the behavior of websites such as Reddit, Medium and so on.

I encourage you to give it a shot, alongside enabling the "Undock Tool Windows" action.

luispabon commented 3 months ago

The problem with it is that it eats nearly half of the viewport for that particular file to display what's basically empty space

mallowigi commented 3 months ago

Well, so is with the feature disabled. You get all the empty space on the right, rather than half the empty space on both sides.

Check how it looks like with the tool windows collapsed:

CleanShot 2024-04-04 at 16 04 40@2x

luispabon commented 3 months ago

image

vs image

The former produces a predictable place for your eyes to start scanning the file, as the margin is always the same. I personally think it's not a good default and hurts ergonomy and especially for those of us already accustomed to intellij's default, but other people might disagree clearly, 100% personal pref.

mallowigi commented 3 months ago

It challenges the habits, that's for sure. But it's the same as when the IntelliJ new UI was introduced, a lot of people were disappointed, but they left the setting as the default for users to "catch on the trend". Obviously, I'm not pushing it without a way to revert to the old behavior.

Think of it this way: in most websites nowadays, the content is often centered in the middle. So why not while coding?

In fact, VScode already introduced that setting (though, it's not the default, I agree with that): CleanShot 2024-04-04 at 16 18 07@2x

AndraxDev commented 3 months ago

No. It's a new feature of the Material Theme UI. It's enabled by default for all users.

I need to write an article about this but bottomline, this centers the editor rather than pin it to the left. This is especially great when the tool windows are collapsed, mimicking the behavior of websites such as Reddit, Medium and so on.

I encourage you to give it a shot, alongside enabling the "Undock Tool Windows" action.

How to disable this feature? Where can I find "Undock Tool Windows" action?

mallowigi commented 3 months ago

Settings > Centered Editor

Luke-Shepp commented 3 months ago

There's a few bug reports gone into phpstorm for this, it's also not mentioned in the plugin changelog / whats new. It's a little odd for a setting like this to be enabled by default

https://youtrack.jetbrains.com/issue/WI-76827 https://youtrack.jetbrains.com/issue/WI-76840/Line-numbers-column-width-too-wide https://youtrack.jetbrains.com/issue/WI-76856/Incorrect-code-window-display-after-update.-34-screen

mallowigi commented 3 months ago

Just like I said previously, it's an opinionated choice.

I apologize for the lack of visibility in the changelog and the documentation. I'll try to find a time to carefully document that, in the meantime, this issue will serve as a reference for future issues of the same nature.

bariod commented 3 months ago

I might enjoy it more if it actually were in the center of the screen, not offset to the right by the project window.

mallowigi commented 3 months ago

I might enjoy it more if it actually were in the center of the screen, not offset to the right by the project window.

This can be achieved by executing the action "undock tool windows"

bariod commented 3 months ago

There isn't a way to combine the two? I.e. docked windows and a "truly" centered editor. This would obviously only work as long as the window is small enough to fit in the empty space to the left of the editor.

mallowigi commented 3 months ago

There are two separate actions. The centered editor feature does just that.

In fact, there is a similar feature like Centered Editor, available in the native IDE called "zen mode". When enabled, it undocks all tool windows and center editors. However it also hides other parts of the ide, and there is no way to control what to hide and what not. The centered editor is like in the middle, it only centers the editor. (In fact, the centered editor and zen mode use the same functionality under the hood).

mallowigi commented 3 months ago

Also, this behavior is consistent with the one you can find in VSCode:

CleanShot 2024-04-05 at 10 19 18@2x

CleanShot 2024-04-05 at 10 19 29@2x

Luke-Shepp commented 3 months ago

Definitely a useful feature on bigger monitors - but when using a 14" macbook screen I collapse all sidebars to get a full width editor, so it needs to be justified left for me. Happy that there's a toggle for it, but it was just confusing as there was nothing mentioned in the changelog when trying to find which plugin or phpstorm version was responsible 😁

mallowigi commented 3 months ago

Yes, I definitely apologize for the lateness in updating the documentation, there's just too much to write about for version 9.0.0 and I didn't find the right time to invest the time for it. (it should still be available in the changelog of the plugin in the Marketplace)

mallowigi commented 3 months ago

Definitely a useful feature on bigger monitors - but when using a 14" macbook screen I collapse all sidebars to get a full width editor, so it needs to be justified left for me. Happy that there's a toggle for it, but it was just confusing as there was nothing mentioned in the changelog when trying to find which plugin or phpstorm version was responsible 😁

I concur that for people who leave tool windows on the left open, they are using them as the left margin for the code to start. For such people having yet another gap might feel irrelevant (and explains somewhat why Zen Mode forces tool windows to be hidden).

Perhaps I should display a notification or a popup explaining the feature for further questions.

luxferre commented 3 months ago

first seen frustrating, now just nice

mallowigi commented 3 months ago

I've finally updated the documentation, hope this will clear up questions from now on

juanjoseluisgarcia commented 3 months ago

Settings > Centered Editor

Where? how? Screenshot please

bariod commented 3 months ago

Settings > Centered Editor

Where? how? Screenshot please

Material Theme UI > Features > Centered Editor https://material-theme.com/docs/what-s-new/#centered-editor

What's new? - Material Theme UI Documentation
The Material Theme plugin is a plugin for JetBrains IDEs (IntelliJ, PhpStorm, WebStorm, Android Studio, etc...) which completely redesigns the UI with a beautiful and configurable Material Design UI. This is the plugin's documentation page which presents and explains the different features provided by the plugin.
luispabon commented 3 months ago

Settings > Centered Editor

Where? how? Screenshot please

Just do a text search for it on the settings window

lhall-amphibee commented 3 months ago

Wow I thought my editor broken down at first. Happily reverted back the option :+1:

Yexeed commented 3 months ago

Yeah, this new options made me waste about ~40 minutes, I've gone through all cycles: denial, anger, trying to run without plugins, with them, disable one-by-one separatly and so on. In the end, I've decided to uninstall plugin and live forward. How lucky I was when before uninstalling this forever I've decided to search for issues page and look for new issues. My default editor appearance is that project tab is enabled in 99% of my code time, making editor "KINDA" centered all the time. Yes, I accept the fact that my habit of centering the editor has grown over the years, I just can't code undistractibly if the project tab is closed, and code goes all the way to the left of the screen. However, enabling this new option by-default when you update for such users as me, creates unmiserable confusion. You definetly should have, before enabling it silently after regular update, think it thorougly. Popping a notification is a real close solution 🤙🏼

mallowigi commented 3 months ago

Next version will pop-up a notification to limit confusion, I hope.

Yexeed commented 3 months ago

No offsense btw; None made. P.s. also when I've updated the plugin, first thing that I've noticed that this newly created blank space which centers the editor, are a very similar to those you get when clicking on 'code-author' inlay hint. That made me think that this blaming tool-window is the reason why editor has been centered, not the material theme plugin. Maybe it is possible for you to add some option to indicate about the blank space in the menu when you right-click it? Also another suggestions, file tabs remain not affected, and are staying in the left, which creates some confusion, maybe you could add an option to the settings menu to affect tabs, alongside with the editor? image image

mallowigi commented 3 months ago

I'm not sure I understand what you're talking about... What is "file tabs" ?

Yexeed commented 3 months ago

I'm not sure I understand what you're talking about... What is "file tabs" ?

Opened files tabs 319579108-bc8b737f-b872-4989-a905-8db0fb5d32ed.png

mallowigi commented 3 months ago

So you mean an option for the tabs to be on the center as well? Unfortunately it is not possible. The toggle centers the code in the middle of the editor, but the tabs are outside the editor. Moreover I don't think this will look good if you ask me.

Let's wait the first editor to implement this and we will see if it makes sense :)

ekvedaras commented 3 months ago

People, just put project view on the right, no need to center anything 😃 but interesting, will try it out 🤔

coder-wuya commented 3 months ago

我找了一早上,终于知道是啥问题了

XuBoZhangQvQ commented 3 months ago

@mallowigi hi,there,I have found the root cause of the problem In the new version, simply adjusting the settings of Material Theme Ul will open the Distraction Free Mode which should be a bug in the new version After adjusting the settings, just manually turn off the Distraction Free Mode

image
mallowigi commented 3 months ago

@mallowigi hi,there,I have found the root cause of the problem

In the new version, simply adjusting the settings of Material Theme Ul will open the Distraction Free Mode which should be a bug in the new version

After adjusting the settings, just manually turn off the Distraction Free Mode

image

It's not a bug, did you read the thread at all?

Vorta commented 3 months ago

Who in their right mind thought that this option should be on by default?

XuBoZhangQvQ commented 3 months ago

@mallowigi hi,there,I have found the root cause of the problem In the new version, simply adjusting the settings of Material Theme Ul will open the Distraction Free Mode which should be a bug in the new version After adjusting the settings, just manually turn off the Distraction Free Mode

image

It's not a bug, did you read the thread at all?

sorry,I really didn't see all of this thread,But on my monitor, it does seem strange to have this feature enabled by default(4K 27 inches 3008×1692)

image
mallowigi commented 3 months ago

Changed the default to false. Gave up on challenging habits.

mallowigi commented 3 months ago

Material Theme UI-9.2.0.zip

Is the default gone with this version?

alexboutros commented 3 months ago

I do not see the option for this under settings > features anymore. I actually like the centered editor.

mallowigi commented 3 months ago

I didn't remove the feature, it should still be inside the settings. Have you checked in all sections of the Features settings page?

alexboutros commented 3 months ago

I didn't remove the feature, it should still be inside the settings. Have you checked in all sections of the Features settings page?

image

I don't see the features page where it used to be under the main Material Theme UI dropdown, only the Features tab in settings, and nothing in there about the centered editor.

Edit: When I open the IDE the editor is centered for a few seconds, and then moves back to the left side. Edit2: The option is only missing for me in Rider. It is there in Webstorm and working great.

mallowigi commented 3 months ago

You are still using the version 8.13

alexboutros commented 3 months ago

You are still using the version 8.13

Should Rider be showing a newer version? I see it's 9.1.0 in webstorm, 8.13.2 in Rider.

mallowigi commented 3 months ago

Only if you have 2024.X