search

AtomMaterialUI / material-theme-issues

Issues Repository for the Material Theme UI plugin for JetBrains
Other
62 stars 4 forks source link

[Bug]: Notifications from Material Theme UI plugin are shown in Japanese #526

Closed jreznot closed 1 month ago

jreznot commented 1 month ago

Describe the bug

Hi, please take a look at the bug we discovered in the last EAP versions

IJPL-156716

To Reproduce

  1. Install Material theme UI plugin in IntelliJ IDEA 2024.2 EAP
  2. Restart
  3. Observe notifications in Japanese

Expected behavior

English locale should be used.

API com.intellij.DynamicBundle#getLocale enables plugins to access the Locale used by user

Material Theme Version

9.4.0

IDE

IntelliJ IDEA

System Info

No response

Logs/Screenshots

No response

jreznot commented 1 month ago

image

mallowigi commented 1 month ago

Umm, do you have the japanese plugin installed?

jreznot commented 1 month ago

Since 2024.2 JetBrains IDEs have ZH, JA, KO locales bundled with IDEs

mallowigi commented 1 month ago

CleanShot 2024-06-21 at 21 58 52@2x

Oh wow. I need to fix that ASAP...

jreznot commented 1 month ago

API com.intellij.DynamicBundle#getLocale enables plugins to access the Locale used by user

mallowigi commented 1 month ago

I've disabled support for 2024.2 EAP. I don't have the time at the moment to handle the new API. Thanks for reporting.

jreznot commented 1 month ago

We would be glad if you had time before the release to change it, it will happen aprox in the end of July

xsy420 commented 1 month ago

temporally fix:

  1. unzip the material-theme-jetbrains-9.4.0-instrmented.jar
  2. change the _ja.properties file in message dir to .properies file
  3. in the material-theme-jetbrains-9.4.0-instrmented directory, run 
    jar -cvf ../material-theme-jetbrains-9.4.0-instrmented.jar *
  4. replace the material-theme-jetbrains-9.4.0-instrmented.jar