search

AtomMaterialUI / mtslack

Customize your Slack experience with tweaks and themes. Includes the famous Material Themes as well as other popular themes such as Monokai Pro, Dracula, Atom One, GitHub, Solarized, Night Owl...
https://mallowigi.github.io/mtslack/
Apache License 2.0
496 stars 23 forks source link

RangeError: value of 'position' is out of range #158

Open rcompier opened 2 years ago

rcompier commented 2 years ago

Describe the bug

Applying mtslack on windwos 10 gives an error:

UnhandledPromiseRejectionWarning: RangeError - the value of 'position' is out of range. Must be an integer, received NaN

To Reproduce

Steps to reproduce the behavior:

  1. Open CMD
  2. Run mtslack
  3. Apply tweaks
  4. Set default location
  5. See error

Expected behavior

Mtslack should copy the config to the clipboard to paste in devtools.

Screenshots

image

Desktop

mallowigi commented 2 years ago

Haven't checked on windows but please make sure you're using node v16+

mallowigi commented 2 years ago

@Saghen ?

rcompier commented 2 years ago

With updating node to v16+, the code doesn't crash anymore.

However, it seems to not affect slack, neither in regular or admin mode.

mallowigi commented 2 years ago

I can't test on Windows at the moment. @Saghen did you test it in your machine ?

Saghen commented 2 years ago

Able to reproduce on my end as well. I'll take a look in the next couple of days, sorry about this

Saghen commented 2 years ago

@mallowigi The fix I posted I had to do for the fork of asar also fixed the issue for windows https://github.com/mallowigi/mtslack/pull/155

mallowigi commented 2 years ago

Have you posted a pr in asar? I'll publish a version if you assure it's ready.

Saghen commented 2 years ago

It works on both my systems on fresh slack installs but it would be worth checking on your system too

Saghen commented 2 years ago

@mallowigi Following up on this. Was the fix I posted in #155 added to the asar package. If not, do you need anything from me to get it out? I can post a PR but it's just that few lines that needed changing

mallowigi commented 2 years ago

Frankly I don't want to invest in this project anymore. The current version with the console code is good enough and I don't want to bother trying to improve especially due to the limitations that I couldn't find a good fix against.

I will keep on adding new css rules when they are added but apart from that I will not publish newer versions.