search

AtomicJar / testcontainers-cloud-setup-action

Apache License 2.0
3 stars 0 forks source link

Add input to define the OS of the runner #1

Closed ilopezluna closed 1 year ago

ilopezluna commented 1 year ago

This PR is totally optional but I thought it could be useful to be able to specify the OS of the runner instead of using always linux. WDYT?

I also changed the way how the suffix is calculated. You can see more details here.

If you keep reading in the thread you will see another approach to determine the binary to use (using url aliases), let us know what do you think as well 🙏

eddumelendez commented 1 year ago

we can use RUNNER_OS in the script and discover the os automatically :) See GHA env vars

we can also do if $RUNNER_OS == 'macOS' then 'darwin'.

WDYT?

ilopezluna commented 1 year ago

we can use RUNNER_OS in the script and discover the os automatically :) See GHA env vars

we can also do if $RUNNER_OS == 'macOS' then 'darwin'.

WDYT?

Updated, no need to any additional parameter now. Tested in ubuntu-latest, windows-latest, macos-latest & ubuntu-18.04 The inline conditional are not readable at all, I didn't find a better way to do it, let me know if you have any suggestion 🙏

lanwen commented 1 year ago

Time to use typescrypt ? :D