Closed matthewjablack closed 4 years ago
This PR improves contracts to follow best practices.
Oraclize.sol
MedianizerInterface.sol
Medianizer.sol
Oracle.sol
public
Medianizer.fund
uint256
uint
Medianizer med
Oracle.setAssetPrice
queryId
require
Description
This PR improves contracts to follow best practices.
Submission Checklist :pencil:
Oraclize.sol
constructor checks that parameters are non-zeroMedianizerInterface.sol
to ensure that cyclic import does not occur betweenMedianizer.sol
andOracle.sol
.public
Medianizer.fund
to useuint256
instead ofuint
Oracle.sol
to ensure uninitialized constantMedianizer med
is initialized in child constructorOracle.setAssetPrice
has extremely long line which is split into multiple linesqueryId
require
statements