AtomicStryker / atomicstrykers-minecraft-mods

Repository for my open source Minecraft Mods
https://atomicstryker.github.io/
180 stars 96 forks source link

Game crashes when beginning to break #467

Closed Camawama closed 1 year ago

Camawama commented 1 year ago

Game crashes when breaking a block. here is the report.

crash-2023-02-11_23.03.36-client.txt

AtomicStryker commented 1 year ago

https://github.com/AtomicStryker/atomicstrykers-minecraft-mods/commit/282aa05223082972344756dd888cd00b5d830f73

I have pushed a concurrency fix into the tick hook, but this should not be happening in the first place. I suspect you have another mod causing this, and will probably run into other issues now...

Multi Mine 1.18.4 is pushed to curse

Camawama commented 1 year ago

Thank you, I will give it another test!

Camawama commented 1 year ago

It it working fine now!

AtomicStryker commented 1 year ago

Good to hear

Camawama commented 1 year ago

Alright, I'm back again to report that it's still broken. Appears to only cause a crash while in singleplayer though!

crash-2023-02-14_10.13.21-client.txt

latest.log

AtomicStryker commented 1 year ago

Ah, i am a fool, it is not another mod causing this concurrency but myself. MC now does packet handling async, which means i have to synchronize the packets or else this happens ...

https://github.com/AtomicStryker/atomicstrykers-minecraft-mods/commit/51e992f345ac221c2b0fc39661a970d393951d9c https://github.com/AtomicStryker/atomicstrykers-minecraft-mods/commit/57eae3791aff058260215f8915de8a603cddd55c

Pushed new versions for 1.18 and 1.19.3 to curse

Camawama commented 1 year ago

You have got to be the most efficient dev out there, my issues are never resolved this fast! Thank you :D

Camawama commented 1 year ago

Now wait, It's once again not working...why is it random??

AtomicStryker commented 1 year ago

Same stack trace?

Camawama commented 1 year ago

Sorry, let me send the logs and stuff again. (Also, I've had no issues server-side and the client doesn't even crash on the server).

image

crash-2023-02-15_10.08.10-client.txt

latest.log

AtomicStryker commented 1 year ago

OK! So i've asked in the forge discord for higher wisdom and got told i am missing a logical side check (client/server), and this may have worked in older Forge versions because of a bug, and doesnt work anymore. This might explain why i never saw your crash in my testing. I have updated the forge versions for 1.18 and 1.19, added the logical side check, tested it in my singleplayer, and pushed new versions to curse https://github.com/AtomicStryker/atomicstrykers-minecraft-mods/commit/6f86ab6295710200628a569ffda2504fc7384eb5 https://github.com/AtomicStryker/atomicstrykers-minecraft-mods/commit/bbdb54a8f77ecbfedfb61875a90b1e0bb4648589

Camawama commented 1 year ago

I tested it singleplayer and multiplayer and am happy to report that it's all working perfectly! Thank you !!!

tzwel commented 1 year ago

any chances this will work in 1.19.2?

AtomicStryker commented 1 year ago

1.19.2.3 will certainly do (its the one from march for 1.19.2) https://legacy.curseforge.com/minecraft/mc-mods/multi-mine/files

tzwel commented 1 year ago

i tried it before, but couldn't be bothered enough to find this issue again it works like a charm, thanks!