search

AtomicStryker / atomicstrykers-minecraft-mods

Repository for my open source Minecraft Mods
https://atomicstryker.github.io/
180 stars 96 forks source link

Modded item support? #508

Closed xJon closed 3 months ago

xJon commented 3 months ago

From looking at the config files, it seems only vanilla item IDs are supported, is that true?

dynamiclights_dropitems.cfg

# Configuration file

general {
    # Item IDs that shine light when dropped in the World.
    S:LightItems=torch,glowstone=12,glowstone_dust=10,lit_pumpkin,lava_bucket,redstone_torch=10,redstone=10,golden_helmet=14

    # Item IDs that do not shine light when dropped and in water, have to be present in LightItems.
    S:TurnedOffByWaterItems=torch,lava_bucket

    # Update Interval time for all Item entities in milliseconds. The lower the better and costlier.
    I:"update Interval"=1000
}

Playing on 1.12.2.

ACGaming commented 3 months ago

Looks like you can provide any item with domain, you can just omit minecraft: when specifying vanilla items: https://github.com/AtomicStryker/atomicstrykers-minecraft-mods/blob/1.12.2/DynamicLights/src/main/java/atomicstryker/dynamiclights/client/ItemConfigHelper.java#L65-L68

AtomicStryker commented 3 months ago

Yes, the only nod to vanilla items is that i automatically add the minecraft: prefix otherwise they are not handled any differently than mod items. Configure away